From: Andi Kleen <andi@firstfloor.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Suresh Siddha <suresh.b.siddha@intel.com>,
Venki Pallipadi <venki@google.com>
Subject: Re: [Patch] Idle balancer: cache align nohz structure to improve idle load balancing scalability
Date: Wed, 19 Oct 2011 21:24:51 -0700 [thread overview]
Message-ID: <m2wrc0xpbg.fsf@firstfloor.org> (raw)
In-Reply-To: <1319060737.2604.38.camel@schen9-DESK> (Tim Chen's message of "Wed, 19 Oct 2011 14:45:37 -0700")
Tim Chen <tim.c.chen@linux.intel.com> writes:
> */
> static struct {
> - atomic_t load_balancer;
> - atomic_t first_pick_cpu;
> - atomic_t second_pick_cpu;
> - cpumask_var_t idle_cpus_mask;
> + atomic_t load_balancer ____cacheline_aligned;
> + atomic_t first_pick_cpu ____cacheline_aligned;
> + atomic_t second_pick_cpu ____cacheline_aligned;
> + cpumask_var_t idle_cpus_mask ____cacheline_aligned;
On large configs idle_cpu_masks may be allocated. May need
more changes to tell the allocator to cache align/pad too?
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-10-20 4:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 21:45 [Patch] Idle balancer: cache align nohz structure to improve idle load balancing scalability Tim Chen
2011-10-20 4:18 ` Eric Dumazet
2011-10-20 5:57 ` Suresh Siddha
2011-10-20 6:43 ` Eric Dumazet
2011-10-20 17:19 ` Tim Chen
2011-10-20 4:24 ` Andi Kleen [this message]
2011-10-20 12:26 ` Venki Pallipadi
2011-10-20 17:31 ` Suresh Siddha
2011-10-20 17:38 ` Peter Zijlstra
[not found] ` <4FF5AC937153B0459463C1A88EB478F20135D6ECB5@orsmsx505.amr.corp.intel.com>
2011-11-01 23:52 ` Suresh Siddha
2011-11-02 13:04 ` Srivatsa Vaddagiri
2011-11-02 13:54 ` Srivatsa Vaddagiri
2011-11-02 15:13 ` Suresh Siddha
2011-11-14 9:32 ` Peter Zijlstra
2011-11-14 19:37 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wrc0xpbg.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=suresh.b.siddha@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox