* checkpatch "unclean" patches
@ 2011-05-08 7:55 Emil Langrock
2011-05-08 14:45 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Emil Langrock @ 2011-05-08 7:55 UTC (permalink / raw)
To: linux-kernel; +Cc: Andy Whitcroft
Hi,
I wanted to send some patches, but checkpatch always tells me that they arent
clean and that I should fix them... but I am sure that the checkpatch.pl is
wrong.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ERROR: need consistent spacing around '*' (ctx:WxV)
#70: FILE: abc.h:70:
+ struct xyz __rcu *bar;
^
CHECK: spinlock_t definition without comment
#92: FILE: abc.h:92:
+ spinlock_t foo; /* protects: bar, foobar, barfoo, kaazaa, flupflup, fafafa,
total: 1 errors, 0 warnings, 1 checks, 1337 lines checked
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I am quite sure that the spacing should not be "struct xyz __rcu * bar" and
that the thing behind "spinlock_t foo;" is a comment.
Should I fix my patches or should checkpatch.pl be fixed?
--
Emil Langrock
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: checkpatch "unclean" patches
2011-05-08 7:55 checkpatch "unclean" patches Emil Langrock
@ 2011-05-08 14:45 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2011-05-08 14:45 UTC (permalink / raw)
To: Emil Langrock; +Cc: linux-kernel, Andy Whitcroft
Emil Langrock <emil.langrock@gmx.de> writes:
>
> Should I fix my patches or should checkpatch.pl be fixed?
Since your patches are fine, checkpatch.pl should be fixed of course. I
generally ignore bogus messages.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-08 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-08 7:55 checkpatch "unclean" patches Emil Langrock
2011-05-08 14:45 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox