Re: [PATCH] perf: Enable function tracing for perf core

[Andi Kleen <andi@firstfloor.org>]

Andi Kleen <andi@firstfloor.org> writes:

> From: Andi Kleen <ak@linux.intel.com>
>
> According to Steven R. there is no reason left to not support
> function tracing for the perf core. This makes it easier to debug
> perf.
>
> Don't remove -pg for the x86 and generic perf core.

Ping! patch is missing review.


>
> Cc: rostedt@goodmis.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  arch/x86/kernel/cpu/Makefile |    1 -
>  kernel/events/Makefile       |    4 ----
>  2 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
> index a0e067d..8eb5d28 100644
> --- a/arch/x86/kernel/cpu/Makefile
> +++ b/arch/x86/kernel/cpu/Makefile
> @@ -5,7 +5,6 @@
>  # Don't trace early stages of a secondary CPU boot
>  ifdef CONFIG_FUNCTION_TRACER
>  CFLAGS_REMOVE_common.o = -pg
> -CFLAGS_REMOVE_perf_event.o = -pg
>  endif
>  
>  # Make sure load_percpu_segment has no stackprotector
> diff --git a/kernel/events/Makefile b/kernel/events/Makefile
> index 103f5d1..a630994 100644
> --- a/kernel/events/Makefile
> +++ b/kernel/events/Makefile
> @@ -1,7 +1,3 @@
> -ifdef CONFIG_FUNCTION_TRACER
> -CFLAGS_REMOVE_core.o = -pg
> -endif
> -
>  obj-y := core.o ring_buffer.o callchain.o
>  
>  obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o

-- 
ak@linux.intel.com -- Speaking for myself only