From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932484Ab1IPWdr (ORCPT ); Fri, 16 Sep 2011 18:33:47 -0400 Received: from plane.gmane.org ([80.91.229.3]:53654 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932334Ab1IPWdo (ORCPT ); Fri, 16 Sep 2011 18:33:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="49266853" From: Andi Kleen To: Wolfgang Grandegger Cc: public-x86-DgEjT+Ai2ygdnm+yROfE0A@plane.gmane.org, SocketCAN Core Mailing List , Willy Lambert , LKML Subject: Re: [PATCH] x86_64: permit to configure ISA support also for x86_64 systems References: <4E731565.5050307@grandegger.com> Date: Fri, 16 Sep 2011 15:33:32 -0700 In-Reply-To: <4E731565.5050307@grandegger.com> (Wolfgang Grandegger's message of "Fri, 16 Sep 2011 11:22:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wolfgang Grandegger writes: > There are 64-bit systems out there, like the ATOM N450, which > have ISA slots. This patch is necessary to get the "sja1000_isa" > Socket-CAN driver working on such systems. Really bad idea. You'll get a zillion non 64bit safe unmaintained old ISA drivers then, a non trivial percentage of them will likely explode when just loaded. Not to speak of the warning load at allyesconfig builds. Maybe define a ISA_64 or so. But it's really a bad idea. -Andi -- ak@linux.intel.com -- Speaking for myself only