Re: [RFC 1/6] scripts/get_abi.py: make it backward-compatible with Python 3.6

Jonathan Corbet
2025-02-04T17:28:09Z

Mauro Carvalho Chehab <mchehab+huawei@kernel.org> writes:

> Despite being introduced on Python 3.6, the original implementation
> was too limited: it doesn't accept anything but the argument.

The original implementation *of f-strings* ?

> Even on python 3.10.12, support was still limited, as more complex
> operations cause SyntaxError:
>
> Exception occurred:
> File ".../linux/Documentation/sphinx/kernel_abi.py", line 48, in <module>
> from get_abi import AbiParser
> File ".../linux/scripts/get_abi.py", line 525
> msg += f"{part}\n{"-" * len(part)}\n\n"
> ^
> SyntaxError: f-string: expecting '}'
>
> Replace f-strings by normal string concatenation when it doesn't
> work on Python 3.6.
>
> Reported-by: Akira Yokosawa <akiyks@gmail.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

So I'm curious ... later in the series, you make 3.9 the minimal version
for the kernel. Given that, is there value in adding compatibility for
older versions here?

Thanks,

jon