From: "Krzysztof Hałasa" <khalasa@piap.pl>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Tim Harvey <tharvey@gateworks.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TDA1997x: fix tda1997x_remove()
Date: Thu, 29 Jul 2021 13:07:57 +0200 [thread overview]
Message-ID: <m335rxbcoi.fsf@t19.piap.pl> (raw)
In-Reply-To: <a1f99432-f11e-fd4d-4956-ae2864f08a2a@xs4all.nl> (Hans Verkuil's message of "Thu, 29 Jul 2021 11:55:47 +0200")
Hans,
Hans Verkuil <hverkuil@xs4all.nl> writes:
>> +++ b/drivers/media/i2c/tda1997x.c
>> @@ -2771,6 +2771,7 @@ static int tda1997x_probe(struct i2c_client *client,
>> goto err_free_media;
>> }
>>
>> + i2c_set_clientdata(client, sd);
>> return 0;
>>
>> err_free_media:
>>
>
> Actually, v4l2_i2c_subdev_init() sets this, and v4l2_i2c_subdev_init() *is* called.
> Does it really crash in tda1997x_remove() without this patch?
Yes, the pointer was once invalid (IIRC), and in other cases NULL.
> If so, then I suspect something else is going on.
I'll investigate further, then.
Thanks,
--
Krzysztof "Chris" Hałasa
Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
prev parent reply other threads:[~2021-07-29 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 10:44 [PATCH] TDA1997x: fix tda1997x_remove() Krzysztof Hałasa
2021-07-29 9:55 ` Hans Verkuil
2021-07-29 11:07 ` Krzysztof Hałasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m335rxbcoi.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox