Re: powernow-k8: broken PSB

[Andi Kleen <ak@muc.de>]

Christoph Terhechte <ct@fdk-berlin.de> writes:

> I'm running Gentoo Linux on an Athlon 64 system (board is Asus 8KV SE
> Deluxe). I was getting the "BIOS error - no PSB" message when trying to
> "modprobe powernow-k8", so I upgraded to 2.6.5-rc3-mm4 which includes
> Pavel Machek's new powernow-k8 driver. Theoretically, it should be
> getting tables through ACPI and ignore the legacy PST/PSB tables, but
> I'm still getting the same error as before and inserting powernow-k8
> fails with this message:
>
> FATAL: Error inserting powernow_k8
> (/lib/modules/2.6.5-rc3-mm4/kernel/arch/x86_64/cpufreq/powernow-k8.ko):
> No such device

You have ACPI disabled right? 

If yes this patch will fix it.

But you should enable it, otherwise the powernow driver works just like 
the old one.

-Andi

diff -u linux/drivers/acpi/processor.c-o linux/drivers/acpi/processor.c
--- linux/drivers/acpi/processor.c-o	2004-04-04 23:35:32.000000000 +0200
+++ linux/drivers/acpi/processor.c	2004-04-05 21:39:37.000000000 +0200
@@ -2372,6 +2372,10 @@
 }
 
 
+/* We keep the driver loaded even when ACPI is not running. 
+   This is needed for the powernow-k8 driver, that works even without
+   ACPI, but needs symbols from this driver */
+
 static int __init
 acpi_processor_init (void)
 {
@@ -2384,12 +2388,12 @@
 
 	acpi_processor_dir = proc_mkdir(ACPI_PROCESSOR_CLASS, acpi_root_dir);
 	if (!acpi_processor_dir)
-		return_VALUE(-ENODEV);
+		return_VALUE(0);
 
 	result = acpi_bus_register_driver(&acpi_processor_driver);
 	if (result < 0) {
 		remove_proc_entry(ACPI_PROCESSOR_CLASS, acpi_root_dir);
-		return_VALUE(-ENODEV);
+		return_VALUE(0);
 	}
 
 	acpi_thermal_cpufreq_init();