public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Rohland <cr@sap.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: cowboy@vnet.ibm.com (Richard A Nelson), linux-kernel@vger.kernel.org
Subject: Re: Linux 2.2.19pre10
Date: 13 Feb 2001 14:59:35 +0100	[thread overview]
Message-ID: <m33ddi7kfs.fsf@linux.local> (raw)
In-Reply-To: <E14SfU5-0001mT-00@the-village.bc.nu>
In-Reply-To: <E14SfU5-0001mT-00@the-village.bc.nu>

Hi Alan,

On Tue, 13 Feb 2001, Alan Cox wrote:
>> Yes, I understand that. But I never got any note that my fix is
>> broken and I still do not understand what's the concern.
> 
> Unless Im misreading the code the segment you poke at has
> potentially been freed before it is written too.

Oh yes I was blind, shame on me. Here comes a fixed version.

Greetings
		Christoph

--- 2.2.19-pre10/ipc/shm.c.orig	Tue Feb 13 14:35:25 2001
+++ 2.2.19-pre10/ipc/shm.c	Tue Feb 13 14:34:49 2001
@@ -337,6 +337,8 @@
 		if (current->euid == shp->u.shm_perm.uid ||
 		    current->euid == shp->u.shm_perm.cuid || 
 		    capable(CAP_SYS_ADMIN)) {
+			/* Do not find it any more */
+			shp->u.shm_perm.key = IPC_PRIVATE;
 			shp->u.shm_perm.mode |= SHM_DEST;
 			if (shp->u.shm_nattch <= 0)
 				killseg (id);


      reply	other threads:[~2001-02-13 13:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-12 17:27 Linux 2.2.19pre10 Alan Cox
2001-02-12 18:00 ` Richard A Nelson
2001-02-12 18:06   ` Alan Cox
2001-02-12 18:33     ` Linux 2.2.19pre10:x! Richard A Nelson
2001-02-12 21:38       ` Alan Cox
2001-02-13 12:23     ` Linux 2.2.19pre10 Christoph Rohland
2001-02-13 13:03       ` Alan Cox
2001-02-13 13:29         ` Christoph Rohland
2001-02-13 13:27           ` Alan Cox
2001-02-13 13:59             ` Christoph Rohland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m33ddi7kfs.fsf@linux.local \
    --to=cr@sap.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cowboy@vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox