From: khalasa@piap.pl (Krzysztof Hałasa)
To: DaeSeok Youn <daeseok.youn@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"sachin.kamat" <sachin.kamat@linaro.org>,
Shaun Laing <shaun@xresource.ca>,
Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
devel <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c
Date: Tue, 04 Mar 2014 07:40:40 +0100 [thread overview]
Message-ID: <m34n3epitz.fsf@t19.piap.pl> (raw)
In-Reply-To: <CAHb8M2AS2w9VBSJS9imU07ydMOZW+M-PD-Ja3iZYSTJ=2GNa-A@mail.gmail.com> (DaeSeok Youn's message of "Mon, 3 Mar 2014 16:01:47 +0900")
DaeSeok Youn <daeseok.youn@gmail.com> writes:
>>> - * match with board's first found interface, otherwise this is first
>>> - * found
>>> + * match with board's first found interface, otherwise this is
>>> + * fisrt found
>> ^^^^^
>> I wonder what's your exact procedure for doing such changes :-)
> "first" word is over 80 line character after applying my previous patch(2/5)
> (previous patch is already merged to staging-next tree :-))
Sure, I meant I'd just break the line without re-typing the first/fisrt
word manually... Never mind.
Anyway, I'd rather aim for improving overall code quality, not just
silence 80-char warning. I'm not a big fan of this warning.
--
Krzysztof Halasa
Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
prev parent reply other threads:[~2014-03-04 6:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 7:36 [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c Daeseok Youn
2014-03-03 6:46 ` Krzysztof Hałasa
2014-03-03 7:01 ` DaeSeok Youn
2014-03-03 7:10 ` Joe Perches
2014-03-03 7:33 ` DaeSeok Youn
2014-03-04 0:22 ` DaeSeok Youn
2014-03-04 6:40 ` Krzysztof Hałasa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34n3epitz.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dulshani.gunawardhana89@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=shaun@xresource.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox