From: James Cloos <cloos@jhcloos.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Added driver for ISL29003 ambient light sensor
Date: Sun, 15 Mar 2009 01:41:58 -0400 [thread overview]
Message-ID: <m34oxvfikh.fsf@lugabout.jhcloos.org> (raw)
In-Reply-To: <1236683979-16178-1-git-send-email-daniel@caiaq.de> (Daniel Mack's message of "Tue, 10 Mar 2009 12:19:39 +0100")
>>>>> "Daniel" == Daniel Mack <daniel@caiaq.de> writes:
Trivial comment on the docs:
Daniel> +mode:
Daniel> + 0: diode1's current (unsigned 16bit) (default)
Daniel> + 1: diode1's current (unsigned 16bit)
Daniel> + 2: difference between diodes (l1 - l2, signed 15bit)
That has diode1 twice. Should it, instead, be:
+mode:
+ 0: diode1's current (unsigned 16bit) (default)
+ 1: diode2's current (unsigned 16bit)
+ 2: difference between diodes (l1 - l2, signed 15bit)
?
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6
next prev parent reply other threads:[~2009-03-15 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 11:19 [PATCH] Added driver for ISL29003 ambient light sensor Daniel Mack
2009-03-15 5:41 ` James Cloos [this message]
[not found] <1235606248-13004-1-git-send-email-daniel@caiaq.de>
[not found] ` <20090226094857.50d0710d@hyperion.delvare>
[not found] ` <20090306160042.GA17800@buzzloop.caiaq.de>
[not found] ` <20090306182432.338b0244@hyperion.delvare>
[not found] ` <20090306181409.GA20135@buzzloop.caiaq.de>
[not found] ` <20090307115449.32f0ab26@hyperion.delvare>
[not found] ` <20090307120631.GA25276@buzzloop.caiaq.de>
[not found] ` <20090307130818.367bcaad@hyperion.delvare>
[not found] ` <20090309210901.GC31367@buzzloop.caiaq.de>
[not found] ` <49B666F9.50209@cam.ac.uk>
2009-03-10 15:15 ` Daniel Mack
2009-03-10 17:49 ` Jonathan Cameron
2009-03-11 0:31 ` Daniel Mack
2009-03-11 4:28 ` Andrew Morton
2009-03-11 8:32 ` Daniel Mack
2009-03-11 16:32 ` Andrew Morton
2009-03-11 16:43 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34oxvfikh.fsf@lugabout.jhcloos.org \
--to=cloos@jhcloos.com \
--cc=daniel@caiaq.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox