From: Andi Kleen <ak@muc.de>
To: "Brad House" <brad_mssw@gentoo.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.0] megaraid 64bit fix/cleanup (AMD64)
Date: Tue, 30 Dec 2003 06:26:43 +0100 [thread overview]
Message-ID: <m34qviyiy4.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <18kst-5Av-1@gated-at.bofh.it> ("Brad House"'s message of "Tue, 30 Dec 2003 06:20:05 +0100")
"Brad House" <brad_mssw@gentoo.org> writes:
>
> diff -ruN linux-2.6.0-gentoo-r1.old/drivers/scsi/megaraid.c
> linux-2.6.0-gentoo-r1/drivers/scsi/megaraid.c
> --- linux-2.6.0-gentoo-r1.old/drivers/scsi/megaraid.c 2003-12-29
> 23:51:43.000000000 -0500
> +++ linux-2.6.0-gentoo-r1/drivers/scsi/megaraid.c 2003-12-29
> 23:54:01.005469936 -0500
> @@ -1292,7 +1292,7 @@
>
> /* Calculate Scatter-Gather info */
> mbox->m_out.numsgelements = mega_build_sglist(adapter, scb,
> - (u32 *)&mbox->m_out.xferaddr, (u32 *)&seg);
> + (dma_addr_t *)&mbox->m_out.xferaddr, (u32 *)&seg);
I'm pretty sure it's completely broken. You're changing the layout of
a data structure that is shared with the firmware. Using a 32bit
int here is fine when the driver sets the correct dma mask or
only stuffs pci_alloc_consistent() memory in there (i think it's
the later here)
Even though the driver prints lots of warnings at compile time it
actually works on AMD64 as is. But in many cases you should
use megaraid2.c instead of megaraid.c.
-Andi
next parent reply other threads:[~2004-01-01 13:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <18kst-5Av-1@gated-at.bofh.it>
2003-12-30 5:26 ` Andi Kleen [this message]
2004-01-01 14:08 ` [PATCH 2.6.0] megaraid 64bit fix/cleanup (AMD64) Brad House
2004-04-16 19:24 Mukker, Atul
-- strict thread matches above, loose matches on Subject: below --
2004-04-16 16:35 Mukker, Atul
2004-04-16 19:21 ` Jord Tanner
[not found] ` <A1E28594-9478-11D8-B5AA-000A95CD704C@wagland.net>
2004-04-22 18:22 ` Jord Tanner
2004-04-22 18:37 ` Christoph Hellwig
2004-04-16 13:56 Jord Tanner
2003-12-30 5:10 Brad House
2003-12-30 5:20 ` Jeff Garzik
2003-12-30 6:26 ` Brad House
2003-12-30 6:35 ` Jeff Garzik
2003-12-30 19:43 ` Samuel Flory
2003-12-30 19:49 ` Brad House
2003-12-30 19:54 ` Samuel Flory
2003-12-30 21:09 ` Brad House
2003-12-30 23:11 ` Matt Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34qviyiy4.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=brad_mssw@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox