public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Terminate i386 local APIC DMI exception table
@ 2004-09-27 11:48 Andi Kleen
  0 siblings, 0 replies; only message in thread
From: Andi Kleen @ 2004-09-27 11:48 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, akpm


[sending directly to Linus because Andrew said he is away] 

The i386 local APIC DMI exception table was not 0 terminated. The dmi
parser would walk into random .data space. Found during code review,
not known to cause problems, but should be still fixed.  I checked all
other DMI tables and they seemed to be ok.

Signed-off-by: Andi Kleen <ak@muc.de>

diff -u linux/arch/i386/kernel/apic.c-o linux/arch/i386/kernel/apic.c
--- linux/arch/i386/kernel/apic.c-o	2004-09-27 12:36:35.000000000 +0200
+++ linux/arch/i386/kernel/apic.c	2004-09-27 13:44:49.000000000 +0200
@@ -1233,7 +1233,8 @@
 static struct dmi_system_id __initdata apic_dmi_table[] = {
 	{ need_local_apic, "Intel C440GX+", {
 	  DMI_MATCH(DMI_BOARD_VENDOR,"Intel"),
-	  DMI_MATCH(DMI_BOARD_NAME,"C440GX+") } }
+	  DMI_MATCH(DMI_BOARD_NAME,"C440GX+") } },
+	{},
 };
 
 /*




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-09-27 11:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-27 11:48 [PATCH] Terminate i386 local APIC DMI exception table Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox