Re: [PATCH: NEW SUBARCHITECTURE FOR 2.5.21] support for NCR voyager (3/4/5xxx series)

James Bottomley
2002-06-14T00:13:30Z

davej@suse.de said:
> Would it make sense for the subarchs to use the generic code where
> possible, and only reimplement it's own (for eg) apic.c as and when it
> actually *needs* to be different ?

That is really the way I've implemented it. The only PC specific file in the
generic directory is mpparse.c (since neither visws nor voyager has an MP
compliant bios). All the shareable files are kept in `kernel' and activated
by config options.

I can certainly move mpparse.c back to kernel and add an extra (non user
visible) config option.

> Sounds quite logical. What does the current patches you have do ? I've
> not had chance to look at them yet.

It creates directories `generic' for the standard pc and `visws'. The voyager
patch creates a `voyager' directory. Alternatively, these could be `mach-pc',
`mach-visws' and `mach-voyager'.

James