Ingo, no more kconfig patches

Adrian Bunk
2008-04-30T23:01:54Z

On Wed, Apr 30, 2008 at 11:13:17PM +0200, Ingo Molnar wrote:
>
> * Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> > > which triggers with the following config:
> > >
> > > http://redhat.com/~mingo/misc/config-Wed_Apr_30_21_43_17_CEST_2008.bad
> > >
> > > the reason is dependency on NEW_LEDS that was not spelled out in the
> > > Kconfig entry of JOYSTICK_XPAD.
> >
> > Xpad can be compiled without LED support so this dependancy is
> > incorrect. JOYSTICK_XPAD_LEDS has proper dependancy on LEDS_CLASS, the
> > rest is Kconfig breakage.
>
> no, you are wrong, read the current Kconfig rules again. If the user can
> create a .config that does not build, it is driver breakage. It always
> was, and has been in the past 15 years.
>
> Kconfig might be extended to make dependencies easier to manage for
> developers but until that is implemented you have to craft your driver's
> dependencies with the current tools in a way that doesnt break the
> build.

Ingo, there are areas in the kernel you know well.

But kconfig is not among them.

This breakage with your .config is *not* caused by an input bug as you
wrongly claim (I'll send a correct fix after some testing).

And the commit that broke it even contains a
Signed-off-by: Ingo Molnar <mingo@elte.hu>

I would really appreciate it if you could send the error message and the
.config but not quick kconfig patches that are often wrong and that you
try to push through the maintainers as you tried here.

Toralf, who does randconfig testing for some years, does exactly this,
and the maintainers and/or I usually pick up his bug reports and work on
getting them fixed properly.

> Ingo

Thanks in advance
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed