From: Sergej Pupykin <ps@lx-ltd.ru>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Bugs in usb-skeleton.c??? :)
Date: 13 Jul 2006 16:33:35 +0400 [thread overview]
Message-ID: <m37j2helb4.fsf@lx-ltd.ru> (raw)
In-Reply-To: <1152791917.3024.39.camel@laptopd505.fenrus.org>
>> As I understand, USB subsystem uses urb->transfer_buffer directly with
>> DMA. I see that usb-skeleton.c and (at least) bluez's hci_usb allocates it
>> without GFP_DMA flag. (skeleton with GFP_KERNEL, bluez with GFP_ATOMIC)
AvdV> I think GFP_DMA means something different than that you think it means.
AvdV> GFP_DMA is a bad old hack that means "this is for ISA bus cards to DMA
AvdV> to/from". Since there are no ISA bus USB controllers... the USB code
AvdV> doesn't need to use GFP_DMA.
Does kmalloc always allocate pages that can be used in DMA?
I see pci_map_single gives address that incremented later without page
boundary checking. Are allocated pages sequented? (usb-ohci.c)
next prev parent reply other threads:[~2006-07-13 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 11:26 Bugs in usb-skeleton.c??? :) Sergej Pupykin
2006-07-13 11:58 ` Arjan van de Ven
2006-07-13 12:33 ` Sergej Pupykin [this message]
2006-07-13 13:00 ` Arjan van de Ven
2006-07-13 13:10 ` Sergej Pupykin
2006-07-13 14:24 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37j2helb4.fsf@lx-ltd.ru \
--to=ps@lx-ltd.ru \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox