Re: PCI Express support for 2.4 kernel

Pete Zaitcev
2003-12-15T04:47:55Z

> Date: Sun, 14 Dec 2003 19:28:37 +0200
> From: Vladimir Kondratiev <vladimir.kondratiev@intel.com>

> +++ linux-2.4.23-pciexp/arch/i386/kernel/pci-i386.h 2003-12-14 11:08:17.000000000 +0200

Generally I'm pretty tolerant of bizzare spacing, but in this
case tabs were mixed into the patch, which causes funny effects.

> +union pci_exp_data {
> + u32 l;
> + u16 w[2];
> + u8 b[4];
> +} __attribute__((packed));

Bogus __attribute__((packed)), but it's only the begining.
Whole thing is used where shifts would have worked.

> +static void pci_express_fini(void)
> +{
> + if (rrbar_virt) { <====== Not trusting own code
> + iounmap(rrbar_virt);
> + }

All in all, raw. Also, a healthy dose of Itanium is prescribed.

-- Pete