From: Andi Kleen <ak@muc.de>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.6][2/5]Support for HPET based timer
Date: Wed, 20 Aug 2003 00:41:20 +0200 [thread overview]
Message-ID: <m37k59s227.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <mmZK.Q4.11@gated-at.bofh.it> ("Pallipadi, Venkatesh"'s message of "Wed, 20 Aug 2003 00:20:12 +0200")
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com> writes:
> /*
> + * Default initialization for 8254 timers. If we use other timers like HPET,
> + * we override this later
> + */
> +void (*wait_timer_tick)(void) = wait_8254_wraparound;
It would be much cleaner to just poll the generic monotonic time source here,
not add more special cases.
> diff -purN linux-2.6.0-test1/arch/i386/kernel/time_hpet.c linux-2.6.0-test1-hpet/arch/i386/kernel/time_hpet.c
> --- linux-2.6.0-test1/arch/i386/kernel/time_hpet.c 1969-12-31 16:00:00.000000000 -0800
> +++ linux-2.6.0-test1-hpet/arch/i386/kernel/time_hpet.c 2003-08-18 20:22:06.000
000000 -0700
Shouldn't that be in arch/i386/kernel/timers/hpet.c ?
Also I suspect it should be made an generic timer object there with
a timer_ops structure. If some hook for that is missing it could be added to
timer_ops and timers/timer.c
When there is already a generic framework to add new timers it would be a shame
not to use it.
-Andi
next parent reply other threads:[~2003-08-19 22:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mmZK.Q4.11@gated-at.bofh.it>
2003-08-19 22:41 ` Andi Kleen [this message]
2003-08-26 23:50 [PATCH][2.6][2/5]Support for HPET based timer Pallipadi, Venkatesh
-- strict thread matches above, loose matches on Subject: below --
2003-08-26 21:43 Mikael Pettersson
2003-08-26 18:31 Pallipadi, Venkatesh
2003-08-26 18:51 ` Andrew Morton
2003-08-26 18:55 ` Andrew Morton
2003-08-26 23:20 ` john stultz
2003-08-20 17:01 Pallipadi, Venkatesh
[not found] <C8C38546F90ABF408A5961FC01FDBF1902C7D1C9@fmsmsx405.fm.intel.com.suse.lists.linux.kernel>
[not found] ` <20030820080513.GB17793@ucw.cz.suse.lists.linux.kernel>
2003-08-20 10:01 ` Andi Kleen
2003-08-20 10:47 ` Mikael Pettersson
2003-08-20 17:09 ` Dave Hansen
2003-08-20 1:30 Pallipadi, Venkatesh
2003-08-20 0:18 Pallipadi, Venkatesh
2003-08-20 8:05 ` Vojtech Pavlik
2003-08-19 19:20 Pallipadi, Venkatesh
2003-08-19 22:39 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37k59s227.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox