From: Andi Kleen <ak@muc.de>
To: Christoph Hellwig <hch@sgi.com>
Cc: John Hesterberg <jh@sgi.com>,
linux-kernel@vger.kernel.org, Robin Holt <holt@sgi.com>
Subject: Re: [PATCH] 2.5.43 CSA, Job, and PAGG
Date: 18 Oct 2002 03:07:08 +0200 [thread overview]
Message-ID: <m37kggpnb7.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <20021017224410.A25801@sgi.com>
Christoph Hellwig <hch@sgi.com> writes:
>
> +#if defined __ia64__
> +#define JID_ERR1 "do_csa_acct: No job table entry for jid 0x%lx.\n"
> +#define JID_ERR2 "csa user job accounting write error %d, jid 0x%lx\n"
> +#define JID_ERR3 "Can't disable csa user job accounting jid 0x%lx\n"
> +#define JID_ERR4 "csa user job accounting disabled, jid 0x%lx\n"
> +#else
> +#define JID_ERR1 "do_csa_acct: No job table entry for jid 0x%llx.\n"
> +#define JID_ERR2 "csa user job accounting write error %d, jid 0x%llx\n"
> +#define JID_ERR3 "Can't disable csa user job accounting jid 0x%llx\n"
> +#define JID_ERR4 "csa user job accounting disabled, jid 0x%llx\n"
> +#endif
>
> Umm, this would be #if __LP64__. But please just always cast
> to long long instead.
__LP64__ is a HP/IA64ism, which is not necessarily defined on other
64bit platforms. The proper way to test for 64bit in the kernel is
#include <linux/types.h>
...
#if BITS_PER_LONG==64
#endif
-Andi
next prev parent reply other threads:[~2002-10-18 1:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 15:21 [PATCH] 2.5.43 CSA, Job, and PAGG John Hesterberg
2002-10-17 16:21 ` Dave Jones
2002-10-17 17:50 ` Robin Holt
2002-10-17 18:52 ` Dave Jones
2002-10-18 2:33 ` Christoph Hellwig
2002-10-18 19:05 ` John Hesterberg
2002-10-21 19:43 ` Christoph Hellwig
2002-10-18 2:44 ` Christoph Hellwig
2002-10-18 1:07 ` Andi Kleen [this message]
2002-10-18 1:22 ` Robin Holt
2002-10-18 14:37 ` Keith Owens
2002-10-18 22:00 ` Christoph Hellwig
2002-10-18 15:43 ` Keith Owens
2002-10-18 16:19 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37kggpnb7.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=hch@sgi.com \
--cc=holt@sgi.com \
--cc=jh@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox