sys_close undefined on x86_64

sys_close undefined on x86_64

[John Stebbins]

Can someone tell me if this is a kernel bug or a problem with the module
I'm trying to compile?

I'm attempting to compile an external module for the PVR-250 mpeg-2
capture card (ivtv module).  The driver is a little behind the times,
but various people have persuaded it to compile and load on 2.6
systems.  I had it running on i386 arch 2.6 kernel earlier.  But I've
since upgraded to x86_64.

insmod fails with sys_close undefined message when attempting to load
the module.

The other sys_ functions seem to be there.

If the use of sys_close has been deprecated or something, could someone
please give me a pointer to the right way to do syscalls in the 2.6
kernels.  I've done some digging and just can't find any useful
information.

I'll be lurking on the kernel-list archives.

Thanks
John

Re: sys_close undefined on x86_64

[Greg KH]

On Sat, Jun 12, 2004 at 05:11:18PM -0700, John Stebbins wrote:
> 
> insmod fails with sys_close undefined message when attempting to load
> the module.

Why would a kernel module want to call sys_close directly?  If it's for
firmware loading, the module needs to be ported to use the firmware
download subsystem.

Good luck,

greg k-h

Re: sys_close undefined on x86_64

[Andi Kleen]

John Stebbins <john@stebbins.name> writes:

> Can someone tell me if this is a kernel bug or a problem with the module
> I'm trying to compile?
>
> I'm attempting to compile an external module for the PVR-250 mpeg-2
> capture card (ivtv module).  The driver is a little behind the times,
> but various people have persuaded it to compile and load on 2.6
> systems.  I had it running on i386 arch 2.6 kernel earlier.  But I've
> since upgraded to x86_64.
>
> insmod fails with sys_close undefined message when attempting to load
> the module.
>
> The other sys_ functions seem to be there.
>
> If the use of sys_close has been deprecated or something, could someone
> please give me a pointer to the right way to do syscalls in the 2.6
> kernels.  I've done some digging and just can't find any useful
> information.

It's just not exported and x86-64 unlike i386 calls in kernel system
calls directly.  In theory it could be exported (stick a
EXPORT_SYMBOL(sys_close) somewhere in the main kernel), however it
would be better to change the driver to not use it and use a private
file or no file at all.

-Andi

Re: sys_close undefined on x86_64

[John Stebbins]

Thanks for the pointer.  I hadn't heard about the firmware download
subsystem.  I just had a look.  Seems to be just the thing needed here.
There are other people actively working on this module, so maybe I can
get it done by just suggesting it to them :->

John

On Sat, 2004-06-12 at 17:28, Greg KH wrote:
> On Sat, Jun 12, 2004 at 05:11:18PM -0700, John Stebbins wrote:
> > 
> > insmod fails with sys_close undefined message when attempting to load
> > the module.
> 
> Why would a kernel module want to call sys_close directly?  If it's for
> firmware loading, the module needs to be ported to use the firmware
> download subsystem.
> 
> Good luck,
> 
> greg k-h