From: khalasa@piap.pl (Krzysztof Hałasa)
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: gregkh@linuxfoundation.org, sachin.kamat@linaro.org,
shaun@xresource.ca, dulshani.gunawardhana89@gmail.com,
dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c
Date: Mon, 03 Mar 2014 07:46:03 +0100 [thread overview]
Message-ID: <m3bnxnpyok.fsf@t19.piap.pl> (raw)
In-Reply-To: <3980699.cFzmTHesZE@daeseok-laptop.cloud.net> (Daeseok Youn's message of "Fri, 28 Feb 2014 16:36:03 +0900")
Daeseok Youn <daeseok.youn@gmail.com> writes:
> clean up checkpatch.pl warnings:
> WARNING: Line length over 80 characters
This warning should be long gone IMHO. It does more harm than good.
> unsigned char *ucp = (unsigned char *) &hi->mfg_info.data;
>
> pr_info("eeprom[00]: %02x %02x %02x %02x %02x %02x %02x %02x\n",
> - *(ucp + 0), *(ucp + 1), *(ucp + 2), *(ucp + 3), *(ucp + 4), *(ucp + 5), *(ucp + 6), *(ucp + 7));
> + *(ucp + 0), *(ucp + 1), *(ucp + 2), *(ucp + 3),
> + *(ucp + 4), *(ucp + 5), *(ucp + 6), *(ucp + 7));
> pr_info("eeprom[08]: %02x %02x %02x %02x %02x %02x %02x %02x\n",
> - *(ucp + 8), *(ucp + 9), *(ucp + 10), *(ucp + 11), *(ucp + 12), *(ucp + 13), *(ucp + 14), *(ucp + 15));
> + *(ucp + 8), *(ucp + 9), *(ucp + 10), *(ucp + 11),
> + *(ucp + 12), *(ucp + 13), *(ucp + 14), *(ucp + 15));
> pr_info("eeprom[16]: %02x %02x %02x %02x %02x %02x %02x %02x\n",
> - *(ucp + 16), *(ucp + 17), *(ucp + 18), *(ucp + 19), *(ucp + 20), *(ucp + 21), *(ucp + 22), *(ucp + 23));
> + *(ucp + 16), *(ucp + 17), *(ucp + 18), *(ucp + 19),
> + *(ucp + 20), *(ucp + 21), *(ucp + 22), *(ucp + 23));
> pr_info("eeprom[24]: %02x %02x %02x %02x %02x %02x %02x %02x\n",
> - *(ucp + 24), *(ucp + 25), *(ucp + 26), *(ucp + 27), *(ucp + 28), *(ucp + 29), *(ucp + 30), *(ucp + 31));
> + *(ucp + 24), *(ucp + 25), *(ucp + 26), *(ucp + 27),
> + *(ucp + 28), *(ucp + 29), *(ucp + 30), *(ucp + 31));
> pr_info("eeprom[32]: %02x %02x %02x %02x %02x %02x %02x %02x\n",
> - *(ucp + 32), *(ucp + 33), *(ucp + 34), *(ucp + 35), *(ucp + 36), *(ucp + 37), *(ucp + 38), *(ucp + 39));
> + *(ucp + 32), *(ucp + 33), *(ucp + 34), *(ucp + 35),
> + *(ucp + 36), *(ucp + 37), *(ucp + 38), *(ucp + 39));
> pr_info("eeprom[40]: %02x %02x %02x %02x %02x %02x %02x %02x\n",
> - *(ucp + 40), *(ucp + 41), *(ucp + 42), *(ucp + 43), *(ucp + 44), *(ucp + 45), *(ucp + 46), *(ucp + 47));
> + *(ucp + 40), *(ucp + 41), *(ucp + 42), *(ucp + 43),
> + *(ucp + 44), *(ucp + 45), *(ucp + 46), *(ucp + 47));
> }
This one is probably an improvement, though... why not use some existing
*hex_dump*() instead?
> - * match with board's first found interface, otherwise this is first
> - * found
> + * match with board's first found interface, otherwise this is
> + * fisrt found
^^^^^
I wonder what's your exact procedure for doing such changes :-)
> #ifdef SBE_MAP_DEBUG
> pr_warning("%s: io remapped from phys %x to virt %x\n",
> - hi->devname, (u_int32_t) hi->addr[j], (u_int32_t) hi->addr_mapped[j]);
> + hi->devname, (u_int32_t) hi->addr[j],
> + (u_int32_t) hi->addr_mapped[j]);
This one is fine, too. The others, I wouldn't touch them.
--
Krzysztof Halasa
Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2014-03-03 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 7:36 [PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c Daeseok Youn
2014-03-03 6:46 ` Krzysztof Hałasa [this message]
2014-03-03 7:01 ` DaeSeok Youn
2014-03-03 7:10 ` Joe Perches
2014-03-03 7:33 ` DaeSeok Youn
2014-03-04 0:22 ` DaeSeok Youn
2014-03-04 6:40 ` Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bnxnpyok.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dulshani.gunawardhana89@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=shaun@xresource.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox