From: Andi Kleen <ak@muc.de>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
marcelo.tosatti@cyclades.com
Subject: Re: [BK PATCH] PCI Express patches for 2.4.27-pre3
Date: Tue, 25 May 2004 00:21:59 +0200 [thread overview]
Message-ID: <m3brkdcvp4.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <1ZuS3-1b4-35@gated-at.bofh.it> (Greg KH's message of "Mon, 24 May 2004 23:10:15 +0200")
Greg KH <greg@kroah.com> writes:
> obj-y += pci-pc.o pci-irq.o
> diff -Nru a/arch/x86_64/kernel/mmconfig.c b/arch/x86_64/kernel/mmconfig.c
> --- /dev/null Wed Dec 31 16:00:00 1969
> +++ b/arch/x86_64/kernel/mmconfig.c Mon May 24 13:52:10 2004
> +static inline void pci_exp_set_dev_base(int bus, int devfn)
> +{
> + u32 dev_base = pci_mmcfg_base_addr | (bus << 20) | (devfn << 12);
> + if (dev_base != mmcfg_last_accessed_device) {
> + mmcfg_last_accessed_device = dev_base;
> + set_fixmap(FIX_PCIE_MCFG, dev_base);
> + }
Please no dynamic fixmap crap on x86-64. Do it like 2.6 does - ioremap()
the complete mmconfig aperture once and just just reference it directly.
Then you can also get rid of the spinlocks in the actual access functions,
since everything will be stateless.
-Andi
next parent reply other threads:[~2004-05-24 22:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1ZuS0-1b4-15@gated-at.bofh.it>
[not found] ` <1ZuS3-1b4-35@gated-at.bofh.it>
2004-05-24 22:21 ` Andi Kleen [this message]
2004-05-24 22:40 ` [BK PATCH] PCI Express patches for 2.4.27-pre3 Greg KH
[not found] ` <1ZE52-8sy-15@gated-at.bofh.it>
[not found] ` <1ZFaF-10N-13@gated-at.bofh.it>
[not found] ` <1ZIrV-3xS-7@gated-at.bofh.it>
[not found] ` <1ZJHt-4At-33@gated-at.bofh.it>
2004-05-25 13:38 ` Andi Kleen
[not found] ` <1ZLpV-5YK-37@gated-at.bofh.it>
[not found] ` <1ZNBb-7QA-1@gated-at.bofh.it>
2004-05-25 17:14 ` Andi Kleen
2004-05-26 6:29 Durairaj, Sundarapandian
2004-05-26 13:48 ` Matthew Wilcox
2004-05-26 17:03 ` Greg KH
2004-05-26 17:30 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2004-05-24 21:01 Greg KH
2004-05-24 21:02 ` Greg KH
2004-05-24 21:02 ` Greg KH
2004-05-25 6:53 ` Arjan van de Ven
2004-05-25 8:00 ` Greg KH
2004-05-25 11:32 ` Matthew Wilcox
2004-05-25 12:54 ` Marcelo Tosatti
2004-05-25 13:01 ` Arjan van de Ven
2004-05-25 13:24 ` Matthew Wilcox
2004-05-25 14:41 ` Greg KH
2004-05-26 2:49 ` Jeff Garzik
2004-05-26 4:29 ` Greg KH
2004-05-25 14:40 ` Greg KH
2004-05-25 16:59 ` Marcelo Tosatti
2004-05-25 17:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3brkdcvp4.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox