The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [patch] mmap-speedup-2.5.42-C3
Date: 15 Oct 2002 23:30:34 +0200	[thread overview]
Message-ID: <m3bs5vl79h.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <3DAC59F7.18678FA6@digeo.com>

Andrew Morton <akpm@digeo.com> writes:

> Yup.  We'd need to be able to perform a search based on "size of hole"
> rather than virtual address.  That really needs a whole new data structure
> and supporting search code, I think...  It also may have side effects
> to do with fragmentation of the virtual address space.

When you oprofile KDE startup you notice that a lot of time is spent in
get_unmapped_area too. The reason is that every KDE process links with
10-20 libraries and ends up with a 40-50 entry /proc/<pid>/maps.

Optimizing this case would be likely useful too, although I suspect
Ingo's last hit cache would already help somewhat.

When you add a funky data structure please trigger it on the number
of mappings at least. e.g. I bet a micro optimized (= uses prefetch) 
single linked list or even array will be always best for <= 10 entries,
which is still not that uncommon in the non KDE world.

Array would be attractive because you can trivially prefetch it,
but would eat more space per mm_struct. Assuming each process has at 
least 5 mappings the cost should be rather small though.

-Andi

  reply	other threads:[~2002-10-15 21:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-15 13:11 [patch] mmap-speedup-2.5.42-C3 Ingo Molnar
2002-10-15 18:09 ` Andrew Morton
2002-10-15 21:30   ` Andi Kleen [this message]
2002-10-16  8:03     ` Ingo Molnar
2002-10-16  8:07       ` Jakub Jelinek
2002-10-16  8:27         ` Ingo Molnar
2002-10-16  8:22           ` Jakub Jelinek
2002-10-16  9:16         ` Andi Kleen
2002-10-16  9:47           ` Ingo Molnar
2002-10-16 12:08             ` Jakub Jelinek
2002-10-16  1:14 ` Saurabh Desai
2002-10-16  8:14   ` Ingo Molnar
2002-10-16 14:52     ` Linus Torvalds
2002-10-16 15:49       ` Arjan van de Ven
2002-10-16 16:10         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3bs5vl79h.fsf@averell.firstfloor.org \
    --to=ak@muc.de \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox