Re: [PATCH] TDA1997x: enable EDID support

Hans Verkuil
2021-06-07T11:12:04Z

Hi Krzysztof,

On 07/06/2021 12:56, Krzysztof Hałasa wrote:
> Without this patch, the TDA19971 chip's EDID is inactive.

Was this wrong from the very beginning? How can this ever have been tested
without an EDID?

If it broke in a later patch, then please add a Fixes tag.

Regards,

Hans

>
> Signed-off-by: Krzysztof Halasa <khalasa@piap.pl>
>
> --- a/drivers/media/i2c/tda1997x.c
> +++ b/drivers/media/i2c/tda1997x.c
> @@ -2233,6 +2233,7 @@ static int tda1997x_core_init(struct v4l2_subdev *sd)
> /* get initial HDMI status */
> state->hdmi_status = io_read(sd, REG_HDMI_FLAGS);
>
> + io_write(sd, REG_EDID_ENABLE, EDID_ENABLE_A_EN | EDID_ENABLE_B_EN);
> return 0;
> }
>
>