From: Peter Osterlund <petero2@telia.com>
To: balagi@justmail.de
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Greg KH" <greg@kroah.com>,
torvalds@osdl.org, alan@redhat.com
Subject: Re: [PATCH 2.6.18] pktcdvd driver module: added sysfs interface
Date: 01 Oct 2006 14:47:58 +0200 [thread overview]
Message-ID: <m3d59ci4n5.fsf@telia.com> (raw)
In-Reply-To: <op.tgqhg1pgiudtyh@master>
"Thomas Maier" <balagi@justmail.de> writes:
> this is a patch for the packet writing module pktcdvd.
> The patch adds a sysfs and a debugfs interface, a Kconfig
> parameter to switch of the procfs interface off and a
> bio write queue congestion handling for the driver.
I think most of these changes are good. However, some comments:
* There are many logically independent parts in this change, so they
should be in separate patches. For example:
- Introduce the DRIVER_NAME #define.
- Add sysfs support.
- Make procfs support optional.
- Implement congestion control.
- Move lots of functions around. (Is it needed at all?)
* You need to add Signed-off-by.
* You should CC Andrew Morton and not Linus. These changes should live
in -mm for a while before going into the main tree.
* The patch is white space damaged. All lines that should start with a
single space start with two spaces.
--
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340
next prev parent reply other threads:[~2006-10-01 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-24 18:05 [PATCH 2.6.18] pktcdvd driver module: added sysfs interface Thomas Maier
2006-10-01 8:20 ` Thomas Maier
2006-10-01 12:47 ` Peter Osterlund [this message]
2006-10-01 18:37 ` Thomas Maier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d59ci4n5.fsf@telia.com \
--to=petero2@telia.com \
--cc=alan@redhat.com \
--cc=balagi@justmail.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox