From: Peter Osterlund <petero2@telia.com>
To: Adrian Bunk <bunk@stusta.de>, Andrew Morton <akpm@osdl.org>
Cc: axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/block/pktcdvd.c: make two functions static
Date: 29 Nov 2004 20:33:39 +0100 [thread overview]
Message-ID: <m3d5xw30x8.fsf@telia.com> (raw)
In-Reply-To: <20041129123307.GN9722@stusta.de>
Adrian Bunk <bunk@stusta.de> writes:
> The patch below makes two needlessly global functions static.
Looks good to me.
> diffstat output:
> drivers/block/pktcdvd.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.10-rc1-mm3-full/drivers/block/pktcdvd.c.old 2004-11-06 20:16:55.000000000 +0100
> +++ linux-2.6.10-rc1-mm3-full/drivers/block/pktcdvd.c 2004-11-06 20:17:22.000000000 +0100
> @@ -2627,7 +2627,7 @@
> .fops = &pkt_ctl_fops
> };
>
> -int pkt_init(void)
> +static int pkt_init(void)
> {
> int ret;
>
> @@ -2663,7 +2663,7 @@
> return ret;
> }
>
> -void pkt_exit(void)
> +static void pkt_exit(void)
> {
> remove_proc_entry("pktcdvd", proc_root_driver);
> misc_deregister(&pkt_misc);
--
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340
next prev parent reply other threads:[~2004-11-29 19:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-24 23:10 [2.6 patch] drivers/block/: some cleanups Adrian Bunk
2004-11-25 10:12 ` Christoph Hellwig
2004-11-29 12:04 ` Adrian Bunk
2004-11-29 12:26 ` [2.6 patch] drivers/block/genhd.c: make a function static Adrian Bunk
2004-11-29 12:26 ` [2.6 patch] drivers/block/paride/ cleanups Adrian Bunk
2004-11-29 12:26 ` [2.6 patch] misc drivers/block/cciss* cleanups Adrian Bunk
2004-11-29 12:26 ` [2.6 patch] drivers/block/cpqarray.c: small cleanups Adrian Bunk
2004-11-29 12:26 ` [2.6 patch] drivers/block/elevator.c: make two functions static Adrian Bunk
2004-11-29 19:36 ` Jens Axboe
2004-11-29 12:26 ` [2.6 patch] floppy.c: make some code static Adrian Bunk
2004-11-29 12:28 ` [2.6 patch] loop.c: make two functions static Adrian Bunk
2004-11-29 12:29 ` [2.6 patch] drivers/block/nbd.c: make some " Adrian Bunk
2004-11-29 12:31 ` [2.6 patch] noop-iosched.c: " Adrian Bunk
2004-11-29 19:36 ` Jens Axboe
2004-11-29 12:33 ` [2.6 patch] drivers/block/pktcdvd.c: make two " Adrian Bunk
2004-11-29 19:33 ` Peter Osterlund [this message]
2004-11-29 12:35 ` [2.6 patch] drivers/block/ps2esdi.c: remove two unused functions Adrian Bunk
2004-11-29 12:36 ` [2.6 patch] drivers/block/rd.c: make two variables static Adrian Bunk
2004-11-29 12:37 ` [2.6 patch] drivers/block/ub.c: make a struct static Adrian Bunk
2004-11-29 16:14 ` Pete Zaitcev
2005-02-24 21:56 ` Adrian Bunk
2004-11-29 12:39 ` [2.6 patch] drivers/block/umem.c: make two functions static Adrian Bunk
2004-11-29 12:40 ` [2.6 patch] drivers/block/xd.c: make a variable static Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d5xw30x8.fsf@telia.com \
--to=petero2@telia.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox