From: Andi Kleen <ak@muc.de>
To: ncunningham@linuxmail.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kill __always_inline
Date: Wed, 01 Sep 2004 01:43:18 +0200 [thread overview]
Message-ID: <m3d616j2ll.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <2zqeK-7JB-3@gated-at.bofh.it> (Nigel Cunningham's message of "Wed, 01 Sep 2004 01:30:10 +0200")
Nigel Cunningham <ncunningham@linuxmail.org> writes:
>
> Excuse me if I'm being ignorant, but I thought always_inline was
> introduced because with some recent versions of gcc, inline wasn't doing
> the job (suspend2, which requires a working inline, was broken by it for
> example). That is to say, doesn't the definition of always_inline vary
> with the compiler version?
It is just inline on some old gcc versions that didn't have
__attribute__((always_inline)). But on these plain inline is usually fine
- it will just inline. Only later versions of gcc broke their inlining
algorithm, but they luckily added this attribute as a workaround.
When you have functions that require inlining always mark them __always_inline
-Andi
next parent reply other threads:[~2004-09-01 0:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2zpiO-72f-37@gated-at.bofh.it>
[not found] ` <2zpC1-7fh-13@gated-at.bofh.it>
[not found] ` <2zpVj-7yW-3@gated-at.bofh.it>
[not found] ` <2zqeK-7JB-3@gated-at.bofh.it>
2004-08-31 23:43 ` Andi Kleen [this message]
2004-08-31 22:13 [2.6 patch] kill __always_inline Adrian Bunk
2004-08-31 22:36 ` Andrew Morton
2004-08-31 22:52 ` Adrian Bunk
2004-08-31 23:01 ` Andrew Morton
2004-08-31 23:12 ` Nigel Cunningham
2004-08-31 23:39 ` Andrew Morton
2004-08-31 23:41 ` Nigel Cunningham
2004-09-02 19:46 ` Adrian Bunk
2004-09-02 23:12 ` Tim Bird
2004-09-02 23:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d616j2ll.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox