From: Andi Kleen <ak@muc.de>
To: prasanna@in.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [1/4] Exceptions Notifier patch
Date: Wed, 11 Aug 2004 18:36:16 +0200 [thread overview]
Message-ID: <m3d61x4oov.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <2s3ZC-7Zq-15@gated-at.bofh.it> (Prasanna S. Panchamukhi's message of "Wed, 11 Aug 2004 18:20:08 +0200")
Prasanna S Panchamukhi <prasanna@in.ibm.com> writes:
Just some cosmetical comments.
>
> +EXPORT_SYMBOL(register_die_chain_notify);
Please name it "register_die_notifier"
>
> static int kstack_depth_to_print = 24;
> +struct notifier_block *i386die_chain;
> +static DECLARE_MUTEX(i386die_chain_mutex);
s/i386//
I don't know why you made this a mutex, a spinlock would
be fine too. But that's a minor issue.
Rest looks ok.
-Andi
next parent reply other threads:[~2004-08-11 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2s3ZC-7Zq-15@gated-at.bofh.it>
2004-08-11 16:36 ` Andi Kleen [this message]
2004-08-12 12:26 ` [1/4] Exceptions Notifier patch Prasanna S Panchamukhi
2004-08-12 13:21 ` Andi Kleen
2004-08-11 16:08 Prasanna S Panchamukhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d61x4oov.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox