Re: [1/4] Exceptions Notifier patch

Andi Kleen
2004-08-11T16:36:54Z

Prasanna S Panchamukhi <prasanna@in.ibm.com> writes:

Just some cosmetical comments.

>
> +EXPORT_SYMBOL(register_die_chain_notify);

Please name it "register_die_notifier"

>
> static int kstack_depth_to_print = 24;
> +struct notifier_block *i386die_chain;
> +static DECLARE_MUTEX(i386die_chain_mutex);

s/i386//

I don't know why you made this a mutex, a spinlock would
be fine too. But that's a minor issue.

Rest looks ok.

-Andi