From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238AbcBOHHy (ORCPT ); Mon, 15 Feb 2016 02:07:54 -0500 Received: from ni.piap.pl ([195.187.100.4]:41406 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbcBOHHx convert rfc822-to-8bit (ORCPT ); Mon, 15 Feb 2016 02:07:53 -0500 From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) To: Arnd Bergmann Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] ARM: ixp4xx: move indirect I/O into common-pci.c References: <1454689262-613421-1-git-send-email-arnd@arndb.de> <1454689262-613421-3-git-send-email-arnd@arndb.de> Date: Mon, 15 Feb 2016 08:07:52 +0100 In-Reply-To: <1454689262-613421-3-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 5 Feb 2016 17:20:50 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 91323 [Feb 15 2016] X-KLMS-AntiSpam-Version: 5.5.9.33 X-KLMS-AntiSpam-Envelope-From: khalasa@piap.pl X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Moebius-Timestamps: 3962773, 3962804, 3962786 X-KLMS-AntiSpam-Info: LuaCore: 411 411 cee0ce4cf75f1886b5e0f6cefd2eb52abbb231a6, Auth:dkim=none X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, 2016/02/11 10:58:17 X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2016/02/14 23:24:00 #7167992 X-KLMS-AntiVirus-Status: Clean, skipped Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > The pointer comparison in is_pci_memory() confuses gcc, so it > starts throwing bogus warnings about the use of possibly uninitialized > variables: > > drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': > arch/arm/include/asm/io.h:101:2: error: 'px_is' may be used uninitialized in this function [-Werror=maybe-uninitialized] > drivers/crypto/ixp4xx_crypto.c: In function 'aead_perform': > drivers/crypto/ixp4xx_crypto.c:1072:5: error: 'lastlen' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > The code is that gets warned about is correct, and we should not warn > about this. Moving the code into a .c file makes the object files > smaller and avoids the warnings. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-ixp4xx/common-pci.c | 98 ++++++++++++++++++++++++++++++++++ > arch/arm/mach-ixp4xx/include/mach/io.h | 95 +++----------------------------- > 2 files changed, 104 insertions(+), 89 deletions(-) Acked-by: Krzysztof Hałasa -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland