From: Andi Kleen <ak@muc.de>
To: Roland McGrath <roland@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86-64 singlestep through sigreturn system call
Date: Sat, 17 Jul 2004 13:12:50 +0200 [thread overview]
Message-ID: <m3eknaj39p.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <2iosE-5Kb-17@gated-at.bofh.it> (Roland McGrath's message of "Fri, 16 Jul 2004 02:10:08 +0200")
Roland McGrath <roland@redhat.com> writes:
>> Anyways, even if I applied your patch there would be still inconsistency
>> because there are several other system calls that use IRET. So I don't
>> see much advantage in adding a special case just for sigreturn.
>
> Now that I see that the difference is due to iret being used, I have a
> different solution that handles all cases. The following patch replaces
> both my previous patch for x86-64 native behavior and my patch for x86-64's
> ia32 support. This patch just directly clones Davide Libenzi's i386 code
> for x86-64 in both 64-bit and 32-bit cases. With this, the behavior of
> single-stepping all system calls is consistent.
Hmm, but now the behaviour for 32bit processes is different from the
native 32bit kernel, since 32bit didn't apply any patch so far AFAIK.
If you send me a patch that just changes the behaviour of 64bit
IRET I would apply it.
-Andi
next parent reply other threads:[~2004-07-17 11:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2imAA-4n7-49@gated-at.bofh.it>
[not found] ` <2iosE-5Kb-17@gated-at.bofh.it>
2004-07-17 11:12 ` Andi Kleen [this message]
2004-07-22 2:16 ` [PATCH] x86-64 singlestep through sigreturn system call Roland McGrath
2004-07-22 6:11 ` Andrew Morton
2004-07-22 22:58 ` Roland McGrath
2004-07-13 0:22 Roland McGrath
2004-07-13 7:23 ` Andi Kleen
2004-07-15 0:56 ` Roland McGrath
2004-07-15 5:46 ` Andi Kleen
2004-07-15 21:13 ` Roland McGrath
2004-07-15 22:06 ` Andi Kleen
2004-07-15 23:57 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eknaj39p.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox