public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Osterlund <petero2@telia.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Matthew Wilcox <matthew@wil.cx>, Ingo Molnar <mingo@elte.hu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <jens.axboe@oracle.com>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done"
Date: 06 Jan 2008 11:17:46 +0100	[thread overview]
Message-ID: <m3fxxb2r79.fsf@telia.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0801051900500.2811@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> Does a patch like this change the behaviour you see at all?

> +			bd_inode->i_size = (loff_t)get_capacity(disk)<<9;

It does fix my scenario, with the trivial fix of adding bdev-> at the
beginning of that line, ie:

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 993f78c..a8ed344 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1191,6 +1191,7 @@ static int do_open(struct block_device *bdev, struct file *file, int for_part)
 			}
 			if (bdev->bd_invalidated)
 				rescan_partitions(bdev->bd_disk, bdev);
+			bdev->bd_inode->i_size = (loff_t)get_capacity(disk)<<9;
 		}
 	}
 	bdev->bd_openers++;

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340

  reply	other threads:[~2008-01-06 12:23 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 16:25 [patch] scsi: revert "[SCSI] Get rid of scsi_cmnd->done" Ingo Molnar
2008-01-02 16:46 ` James Bottomley
2008-01-02 19:19   ` Linus Torvalds
2008-01-02 19:40     ` Matthew Wilcox
2008-01-02 19:57       ` Linus Torvalds
2008-01-02 20:17         ` Christoph Hellwig
2008-01-02 20:49           ` Linus Torvalds
2008-01-02 20:53             ` Matthew Wilcox
2008-01-02 20:18         ` Matthew Wilcox
2008-01-02 20:12       ` James Bottomley
2008-01-02 20:45         ` Linus Torvalds
2008-01-02 23:33           ` James Bottomley
2008-01-03  1:58             ` Linus Torvalds
2008-01-06  2:55               ` Peter Osterlund
2008-01-06  3:43                 ` Linus Torvalds
2008-01-06 10:17                   ` Peter Osterlund [this message]
2008-01-06 14:04                   ` James Bottomley
2008-01-06 14:42                   ` James Bottomley
2008-01-06 15:01                     ` Peter Osterlund
2008-01-06 18:14                     ` Linus Torvalds
2008-01-06 18:44                       ` Linus Torvalds
2008-01-06 18:54                         ` James Bottomley
2008-01-06 16:19                   ` Boaz Harrosh
2008-01-06 16:47                     ` James Bottomley
2008-01-06 13:57                 ` James Bottomley
2008-01-06 14:47                   ` Ingo Molnar
2008-01-06 15:20                     ` James Bottomley
2008-01-06 15:45                       ` Adrian Bunk
2008-01-06 16:00                         ` James Bottomley
2008-01-06 16:12                       ` Ingo Molnar
2008-01-06 17:10                         ` James Bottomley
2008-01-08 16:55                           ` Ingo Molnar
2008-01-06 17:11                       ` Matthew Wilcox
2008-01-06 17:36                         ` James Bottomley
2008-01-06 18:34                           ` Willy Tarreau
2008-01-06 18:56                             ` Adrian Bunk
2008-01-06 19:10                               ` Willy Tarreau
2008-01-06 19:58                                 ` Adrian Bunk
2008-01-06 21:08                                   ` Willy Tarreau
2008-01-06 22:25                                     ` Adrian Bunk
2008-01-07 20:50                                     ` Valdis.Kletnieks
2008-01-07 21:31                                       ` Alan Cox
2008-01-07 21:37                                       ` Matthew Wilcox
2008-01-07 23:04                                         ` Valdis.Kletnieks
2008-01-07 23:19                                           ` Matthew Wilcox
2008-01-08 16:47                                             ` Stefan Richter
2008-01-08 17:11                                               ` Linus Torvalds
2008-01-08 20:01                                                 ` Ingo Molnar
2008-01-09  4:01                                             ` Valdis.Kletnieks
2008-01-09  4:10                                               ` Andrew Morton
2008-01-09  6:03                                                 ` Willy Tarreau
2008-01-09  4:03                                             ` Valdis.Kletnieks
2008-01-07 15:25                                 ` John Stoffel
2008-01-07 19:04                                   ` Stefan Richter
2008-01-07 19:59                                     ` John Stoffel
2008-01-06 17:29                     ` Stefan Richter
2008-01-06 20:26                       ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2008-01-06 13:55 Thomas Meyer
2008-01-06 16:56 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fxxb2r79.fsf@telia.com \
    --to=petero2@telia.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox