From: Andi Kleen <ak@muc.de>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ipw2100 wireless driver
Date: Wed, 14 Jul 2004 16:07:52 +0200 [thread overview]
Message-ID: <m3fz7usmvb.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <2hRQ5-7bn-9@gated-at.bofh.it> (Vojtech Pavlik's message of "Wed, 14 Jul 2004 15:20:09 +0200")
Vojtech Pavlik <vojtech@suse.cz> writes:
>
> Wouldn't "struct sk_buff **fragments" be a more correct fix?
No, that would be a pointer to an array instead of the array itself.
Completely different thing.
The best would be struct sk_buff *fragments[0];
[] here is C99, which 2.95 didn't even attempt to support.
-Andi
>> --- ipw2100-ofic/ieee80211.h 2004-07-09 06:32:17.000000000 +0200
>> +++ ipw2100-0.49/ieee80211.h 2004-07-14 13:18:50.000000000 +0200
>> @@ -440,7 +440,7 @@
>> u16 reserved;
>> u16 frag_size;
>> u16 payload_size;
>> - struct sk_buff *fragments[];
>> + struct sk_buff *fragments[1];
next parent reply other threads:[~2004-07-14 14:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2hQr1-62p-23@gated-at.bofh.it>
[not found] ` <2hRQ5-7bn-9@gated-at.bofh.it>
2004-07-14 14:07 ` Andi Kleen [this message]
2004-07-14 14:59 ` ipw2100 wireless driver Vojtech Pavlik
2004-07-14 11:41 Pavel Machek
2004-07-14 11:48 ` Jeff Chua
2004-07-14 11:55 ` Pavel Machek
2004-07-14 14:53 ` Éric Brunet
2004-07-14 15:24 ` Emiliano 'AlberT' Gabrielli
2004-08-09 20:15 ` Tomas Szepe
2004-08-10 5:02 ` Jeff Chua
2004-08-10 6:55 ` Christoph Hellwig
2004-08-10 10:16 ` Pavel Machek
2004-08-10 10:34 ` Christoph Hellwig
2004-08-11 12:17 ` Pavel Machek
2004-08-11 17:54 ` Jeff Garzik
2004-08-11 20:27 ` Pavel Machek
2004-08-11 22:01 ` Jeff Garzik
2004-08-11 10:16 ` James Ketrenos
2004-08-11 10:44 ` Christoph Hellwig
2004-08-11 10:53 ` Wichert Akkerman
2004-08-11 10:59 ` Christoph Hellwig
2004-08-11 16:21 ` James Ketrenos
2004-08-11 16:30 ` Stephen Hemminger
2004-08-11 16:33 ` Tomas Szepe
2004-08-11 16:51 ` Christoph Hellwig
2004-08-11 17:02 ` Tomas Szepe
2004-08-11 17:11 ` Christoph Hellwig
2004-08-11 17:22 ` Tomas Szepe
2004-08-11 17:41 ` Christoph Hellwig
2004-08-11 17:51 ` Tomas Szepe
2004-08-11 22:43 ` David Woodhouse
2004-08-11 22:56 ` Tomas Szepe
2004-08-11 23:06 ` David Woodhouse
2004-08-11 23:11 ` Tomas Szepe
2004-08-11 23:21 ` David Woodhouse
2004-08-11 18:55 ` John Stoffel
2004-08-11 23:55 ` Jeff Chua
2004-08-12 3:47 ` Luis R. Rodriguez
2004-08-11 17:51 ` Jeff Garzik
2004-07-14 12:30 ` Tomas Szepe
2004-07-14 12:27 ` Pavel Machek
2004-07-14 13:15 ` Vojtech Pavlik
2004-07-14 13:42 ` Pavel Machek
2004-07-14 17:00 ` Victor J. Orlikowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fz7usmvb.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox