From: Andi Kleen <ak@muc.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [patch] bug in cpuid & msr on nosmp machine
Date: Sat, 22 May 2004 10:13:01 +0200 [thread overview]
Message-ID: <m3iseoq3qq.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <1XSc3-5y3-23@gated-at.bofh.it> (Andrew Morton's message of "Sat, 22 May 2004 02:00:14 +0200")
Andrew Morton <akpm@osdl.org> writes:
> Rusty Russell <rusty@rustcorp.com.au> wrote:
>>
>> On Thu, 2004-05-20 at 17:32, Andrew Morton wrote:
>> > I think what you want here is
>> >
>> > if (!cpu_possible(cpu) || !cpu_online(cpu))
>> > return -ENXIO;
>>
>> It works, but it's not really correct. cpu_possible() is correct, but
>> cpu_online() might no longer be true by the time do_cpu_read() calls
>> do_cpu_id().
>
> mutter. Are we likely to see any ia32 or x86_64 hotplug-cpu machines?
Yes. Think vmware and virtualization, where partitions could get CPUs
added and removed at runtime.
-Andi
next parent reply other threads:[~2004-05-22 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1XCh4-1jO-67@gated-at.bofh.it>
[not found] ` <1XRg3-4LW-31@gated-at.bofh.it>
[not found] ` <1XRg3-4LW-29@gated-at.bofh.it>
[not found] ` <1XSc3-5y3-23@gated-at.bofh.it>
2004-05-22 8:13 ` Andi Kleen [this message]
2004-05-19 16:35 [patch] bug in cpuid & msr on nosmp machine matthieu castet
2004-05-19 17:46 ` matthieu castet
2004-05-20 2:44 ` Jeff Sipek
2004-05-20 9:51 ` Paul Jackson
2004-05-20 7:32 ` Andrew Morton
2004-05-20 8:34 ` Rusty Russell
2004-05-20 8:51 ` Andrew Morton
2004-05-20 9:30 ` Rusty Russell
2004-05-20 9:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iseoq3qq.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox