Re: PCI Express support for 2.4 kernel

Arjan van de Ven
2003-12-17T08:23:20Z

On Wed, Dec 17, 2003 at 01:55:40AM -0500, Jeff Garzik wrote:
> Linus Torvalds wrote:
> >So if this will only matter for PCI-X drivers and not for discovery etc, I
> >wonder if it wouldn't make sense to have this as a totally separate
> >function? Instead of trying to make the existing "pci_config_xxxx()"
> >stuff work with PCI-X, wouldn't it be nicer to have the driver just map
> >its config space on probe?
>
> Not a bad idea... After posting yesterday on this thread, I had the
> thought: Just like PCI has readl() and sbus has sbus_readl(), why not
> pciex_cfg_readl() ?
>
> Any PCI-Ex drivers would obviously _know_ they are PCI Ex, and they
> could communicate that by virtue of simply using new functions. Older
> drivers for older hardware would use the old API and not care...
> Further, PCI-Ex operations are already basically readl/writel anyway, so
> going through the forest of pci_cfg_ops pointers and such would just add
> needless layering.

BUT powermanagement and co will need to potentially do stuff too with the
config space...