From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263579AbTDDACH (for ); Thu, 3 Apr 2003 19:02:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263580AbTDDACH (for ); Thu, 3 Apr 2003 19:02:07 -0500 Received: from trained-monkey.org ([209.217.122.11]:10765 "EHLO trained-monkey.org") by vger.kernel.org with ESMTP id S263579AbTDDACF (for ); Thu, 3 Apr 2003 19:02:05 -0500 To: Russell King Cc: linux-kernel@vger.kernel.org, alan@redhat.com, Marcelo Tosatti Subject: Re: [patch 2.4] make tty->count atomic_t References: <16012.27749.781757.8312@trained-monkey.org> <20030404000608.B18485@flint.arm.linux.org.uk> <20030404002852.D18485@flint.arm.linux.org.uk> From: Jes Sorensen Date: 03 Apr 2003 19:13:27 -0500 In-Reply-To: <20030404002852.D18485@flint.arm.linux.org.uk> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Russell" == Russell King writes: Russell> On Thu, Apr 03, 2003 at 06:18:22PM -0500, Jes Sorensen wrote: Russell> Isn't release_dev() only called under the BKL, which Russell> guarantees the old "single-thread in the kernel at a time" Russell> behaviour from pre-SMP Linux ? >> It's called from tty_release() and tty_open(). tty_release() grabs >> the BKL but I don't see the path that grabs it when calling through >> tty_open() (doesn't mean I am not blind of course ;-). Russell> It's hidden away in fs/devices.c:chrdev_open() Good point, ok back to the drawing broad ;-( Thanks, Jes