From: John Covici <covici@ccs.covici.com>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.6 PPP deflate breakage on UP
Date: Tue, 19 Mar 2002 01:31:20 -0500 [thread overview]
Message-ID: <m3k7s9f4qv.fsf@ccs.covici.com> (raw)
In-Reply-To: <200203101643.RAA02302@harpo.it.uu.se>
The following patch also works, but may not be the most elegant in the
world.
--- ppp_deflate.c.orig Mon Mar 18 03:42:05 2002
+++ ppp_deflate.c Mon Mar 18 12:28:48 2002
@@ -41,6 +41,8 @@
#include <linux/ppp-comp.h>
#include <linux/zlib.h>
+#include <asm/softirq.h>
+extern asmlinkage void do_softirq();
static spinlock_t comp_free_list_lock = SPIN_LOCK_UNLOCKED;
static LIST_HEAD(comp_free_list);
on Sun, 10 Mar 2002 17:43:43 +0100 (MET) Mikael Pettersson <mikpe@csd.uu.se> wrote:
> In kernel 2.5.6, PPP deflate isn't compiled correctly if CONFIG_SMP
> is off: the macros local_bh_enable() and local_bh_disable() aren't
> expanded and instead turn into references to undefined functions.
> The problem is that <linux/smp_lock.h> is insufficient in UP configs.
>
> The patch below adds an #include <linux/interrupt.h> which works
> around this. I'm not sure about <linux/smp_lock.h>: it really doesn't
> look appropriate for the locking primitives being used in ppp_deflate.c.
>
> /Mikael
>
> --- linux-2.5.6/drivers/net/ppp_deflate.c.~1~ Sat Mar 9 12:53:13 2002
> +++ linux-2.5.6/drivers/net/ppp_deflate.c Sun Mar 10 14:32:04 2002
> @@ -35,6 +35,7 @@
> #include <linux/slab.h>
> #include <linux/vmalloc.h>
> #include <linux/init.h>
> +#include <linux/interrupt.h>
> #include <linux/smp_lock.h>
>
> #include <linux/ppp_defs.h>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
John Covici
covici@ccs.covici.com
prev parent reply other threads:[~2002-03-19 6:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-10 16:43 [PATCH] 2.5.6 PPP deflate breakage on UP Mikael Pettersson
2002-03-11 10:37 ` David Woodhouse
2002-03-19 6:31 ` John Covici [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k7s9f4qv.fsf@ccs.covici.com \
--to=covici@ccs.covici.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox