From: khalasa@piap.pl (Krzysztof Hałasa)
To: "Lino Sanfilippo" <LinoSanfilippo@gmx.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Aw: BUG: Wrong dma queue handling in ixp4 driver
Date: Fri, 22 Jul 2016 12:14:51 +0200 [thread overview]
Message-ID: <m3lh0urnc4.fsf@t19.piap.pl> (raw)
In-Reply-To: <trinity-28228d79-2b64-4d9c-89c2-6ce288a8ed49-1468927909503@3capp-gmx-bs21> (Lino Sanfilippo's message of "Tue, 19 Jul 2016 13:31:49 +0200")
Hi Lino,
"Lino Sanfilippo" <LinoSanfilippo@gmx.de> writes:
>> maybe I miss something, but the ixp4 ethernet driver seems to handle dma pools
>> in a wrong way: In init_queues() it creates a dma pool for descriptors and then
>> only allocates a single descriptor from this pool. The author seems to assume the whole
>> table has been allocated already, since after that the complete pool size is zeroed:
>>
>
> Sorry, I indeed missed something. The allocation is correct. A pool is not required, though,
> since only one chunk is allocated.
Not really: there is one pool for all ports, but each port uses
a separate desc_tab (allocated from that pool).
--
Krzysztof Halasa
Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2016-07-22 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 11:05 BUG: Wrong dma queue handling in ixp4 driver Lino Sanfilippo
2016-07-19 11:31 ` Aw: " Lino Sanfilippo
2016-07-22 10:14 ` Krzysztof Hałasa [this message]
2016-07-22 11:10 ` Aw: " Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lh0urnc4.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=LinoSanfilippo@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox