Re: Linux 3.13-rc1 is out

James Cloos
2013-11-23T01:09:18Z

This combination:

# CONFIG_SYSTEM_TRUSTED_KEYRING is not set
CONFIG_TRUSTED_KEYS=m

(acquired by oldconfig and N to system keyring)

fails with:

Pass 2
CC [M] crypto/asymmetric_keys/x509_rsakey-asn1.o
CC [M] crypto/asymmetric_keys/x509_cert_parser.o
CC [M] crypto/asymmetric_keys/x509_public_key.o
crypto/asymmetric_keys/x509_public_key.c: In function ‘x509_key_preparse’:
crypto/asymmetric_keys/x509_public_key.c:237:35: error: ‘system_trusted_keyring’ undeclared (first use in this function)
ret = x509_validate_trust(cert, system_trusted_keyring);
^
crypto/asymmetric_keys/x509_public_key.c:237:35: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [crypto/asymmetric_keys/x509_public_key.o] Error 1
make[1]: *** [crypto/asymmetric_keys] Error 2
make: *** [crypto] Error 2

Perhaps include/keys/system_keyring.h should have a definition for
system_trusted_keyring in the #ifndef CONFIG_SYSTEM_TRUSTED_KEYRING
case (which may entail just removing the #ifdef).

Commits b56e5a17b6b9acd1 and 09fbc47373826d67 are relevant.

-JimC
--