From: Krzysztof Halasa <khc@pm.waw.pl>
To: Stefan Assmann <sassmann@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
kaneshige.kenji@jp.fujitsu.com, matthew@wil.cx,
ddutile@redhat.com
Subject: Re: GT/s vs Gbps for PCIe bus speed
Date: Wed, 14 Oct 2009 20:51:04 +0200 [thread overview]
Message-ID: <m3ljjdstbb.fsf@intrepid.localdomain> (raw)
In-Reply-To: <4AD58EEE.4070405@redhat.com> (Stefan Assmann's message of "Wed, 14 Oct 2009 10:42:22 +0200")
Stefan Assmann <sassmann@redhat.com> writes:
> IMHO this is rather confusing, as most people don't know what GT/s means.
It's trivial to look it up, isn't it?
> So I'd suggest the following change:
>
> --- a/drivers/pci/hotplug/pci_hotplug_core.c
> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
> @@ -86,8 +86,8 @@ static char *pci_bus_speed_strings[] = {
> "66 MHz PCIX 533", /* 0x11 */
> "100 MHz PCIX 533", /* 0x12 */
> "133 MHz PCIX 533", /* 0x13 */
> - "2.5 GT/s PCI-E", /* 0x14 */
> - "5.0 GT/s PCI-E", /* 0x15 */
> + "2.5 Gbps PCI-E", /* 0x14 */
> + "5.0 Gbps PCI-E", /* 0x15 */
Isn't it like calling 100BASE-TX a 125 Mb/s? _That_ would be confusing.
BTW PCI-E can be multi-lane so Mb/s (and even MB/s) don't make sense.
I guess many people don't know what a MHz is either but we don't say
133 MHz = 133 Mbps.
--
Krzysztof Halasa
next prev parent reply other threads:[~2009-10-14 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 8:42 GT/s vs Gbps for PCIe bus speed Stefan Assmann
2009-10-14 18:51 ` Krzysztof Halasa [this message]
2009-10-14 19:49 ` Don Dutile
2009-10-14 20:50 ` Roland Dreier
2009-10-15 7:32 ` Kenji Kaneshige
2009-10-14 21:33 ` Krzysztof Halasa
2009-10-14 22:51 ` Don Dutile
2009-10-15 7:40 ` Roland Dreier
2009-10-15 14:05 ` Don Dutile
2009-10-15 17:58 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ljjdstbb.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=ddutile@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox