From: Peter Osterlund <petero2@telia.com>
To: Dave Jones <davej@redhat.com>
Cc: Thomas Dillig <tdillig@stanford.edu>, linux-kernel@vger.kernel.org
Subject: Re: Null dereference errors in the kernel
Date: 19 Jul 2006 00:37:33 +0200 [thread overview]
Message-ID: <m3lkqqv8sy.fsf@telia.com> (raw)
In-Reply-To: <20060718164023.GA29417@redhat.com>
Dave Jones <davej@redhat.com> writes:
> On Mon, Jul 17, 2006 at 08:49:19PM -0700, Thomas Dillig wrote:
>
> > 144 drivers/char/agp/ati-agp.c
> > NULL dereference of variable "ati_generic_private.gatt_pages" in
> > function call (drivers/char/agp/ati-agp.c:ati_free_gatt_pages).
>
> I think this is a false positive.
I don't think so. If the 'entry = kzalloc(...)' fails at line 125, the
code will set tables to NULL and retval to != 0. ati_free_gatt_pages()
will then be called with .gatt_pages == NULL and .num_tables > 0. This
will trigger a NULL pointer dereference in ati_free_gatt_pages().
--
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340
next prev parent reply other threads:[~2006-07-18 22:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-18 3:49 Null dereference errors in the kernel Thomas Dillig
2006-07-18 5:02 ` Joshua Henderson
2006-07-18 5:44 ` Thomas Dillig
2006-07-18 9:24 ` Daniel Drake
2006-07-18 12:45 ` Dmitry Torokhov
2006-07-18 14:02 ` Daniel Drake
2006-07-18 16:40 ` Dave Jones
2006-07-18 22:37 ` Peter Osterlund [this message]
2006-07-18 20:55 ` Stefan Richter
2006-07-18 21:16 ` Luiz Fernando N. Capitulino
2006-07-18 21:30 ` Andreas Schwab
2006-07-18 22:46 ` Luiz Fernando N. Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lkqqv8sy.fsf@telia.com \
--to=petero2@telia.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tdillig@stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox