From: Andi Kleen <ak@muc.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.6-rc3: modular DVB tda1004x broken
Date: Sun, 02 May 2004 01:26:59 +0200 [thread overview]
Message-ID: <m3llkbybi4.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <1RbW9-8sE-17@gated-at.bofh.it> (Andrew Morton's message of "Sun, 02 May 2004 01:20:09 +0200")
Andrew Morton <akpm@osdl.org> writes:
>
> Maybe we should change __syscall_return() to return the -ve errno rather
> than -1?
>
>
> diff -puN include/asm-i386/unistd.h~a include/asm-i386/unistd.h
> --- 25/include/asm-i386/unistd.h~a 2004-05-01 16:09:35.115389384 -0700
> +++ 25-akpm/include/asm-i386/unistd.h 2004-05-01 16:09:49.513200584 -0700
> @@ -295,10 +295,6 @@
>
> #define __syscall_return(type, res) \
> do { \
> - if ((unsigned long)(res) >= (unsigned long)(-125)) { \
> - errno = -(res); \
> - res = -1; \
> - } \
> return (type) (res); \
> } while (0)
Don't do that please. That will break all the user space
programs who use asm/unistd.h to define own system calls
(it is quite common).
Make it conditional on __KERNEL__
-Andi
next prev parent reply other threads:[~2004-05-01 23:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1PMQ9-5K6-3@gated-at.bofh.it>
2004-04-28 14:48 ` Linux 2.6.6-rc3 Vincent C Jones
2004-04-28 16:00 ` Sam Ravnborg
2004-04-28 17:24 ` Jari Ruusu
2004-04-28 19:08 ` Sam Ravnborg
2004-04-28 19:18 ` Vincent C Jones
[not found] ` <1PVTx-4rY-25@gated-at.bofh.it>
[not found] ` <1R9hC-6rC-3@gated-at.bofh.it>
[not found] ` <1Rbjr-7Y5-17@gated-at.bofh.it>
[not found] ` <1RbW9-8sE-17@gated-at.bofh.it>
2004-05-01 23:26 ` Andi Kleen [this message]
2004-05-01 23:34 ` 2.6.6-rc3: modular DVB tda1004x broken Andrew Morton
2004-04-28 2:03 Linux 2.6.6-rc3 Linus Torvalds
2004-04-28 11:56 ` Eyal Lebedinsky
2004-05-01 20:13 ` 2.6.6-rc3: modular DVB tda1004x broken Adrian Bunk
2004-05-01 22:02 ` Johannes Stezenbach
2004-05-01 22:14 ` Andrew Morton
2004-05-01 22:37 ` Linus Torvalds
2004-05-01 23:10 ` Andrew Morton
2004-05-01 23:55 ` Linus Torvalds
2004-05-02 0:00 ` Chris Wedgwood
2004-05-02 0:03 ` Andrew Morton
2004-05-02 0:28 ` Linus Torvalds
2004-05-02 0:51 ` Andrew Morton
2004-05-02 1:16 ` Paul Mackerras
2004-05-03 18:06 ` David Mosberger
2004-05-03 18:20 ` Linus Torvalds
2004-05-03 18:30 ` David Mosberger
2004-05-03 18:37 ` Linus Torvalds
2004-05-03 20:42 ` Linus Torvalds
2004-05-03 20:56 ` David Mosberger
2004-05-03 21:07 ` Arjan van de Ven
2004-05-03 22:39 ` David Mosberger
2004-05-04 7:55 ` Arjan van de Ven
2004-05-04 16:44 ` David Mosberger
2004-05-04 16:47 ` Arjan van de Ven
2004-05-03 21:02 ` Andrew Morton
2004-05-03 21:06 ` Arjan van de Ven
2004-05-03 21:16 ` viro
2004-05-03 21:24 ` Jörn Engel
2004-05-03 21:54 ` viro
2004-05-03 22:01 ` viro
2004-05-03 22:33 ` Jörn Engel
2004-05-04 0:14 ` viro
2004-05-04 9:23 ` Jörn Engel
2004-05-04 12:13 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3llkbybi4.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox