Re: 2.6.6-rc3: modular DVB tda1004x broken

viro
2004-05-03T21:16:15Z

On Mon, May 03, 2004 at 02:02:51PM -0700, Andrew Morton wrote:
> Linus Torvalds <torvalds@osdl.org> wrote:
> >
> >
> >
> > How about this patch?
>
> Seems sane. For after 2.6.6 ;)
>
> > +static inline long open(const char * name, int mode, int flags)
> > +{
> > + return sys_open((const char __user *) name, mode, flags);
> > +}
>
> We may as well stick the get_fs()/set_fs() stuff in here as well - all
> callers need to do it, after all. After which it would best be uninlined.

I'd rather kill open() completely - we only have a handful of in-tree users
and there's no good reason to keep that crap, AFAICS. I'm gathering the
list of in-tree callers of open()/lseek()/close() and so far a lot of them
look buggy. More on that later...