Re: 2.6.6-rc3: modular DVB tda1004x broken

Arjan van de Ven
2004-05-03T21:09:50Z

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Mon, 2004-05-03 at 23:02, Andrew Morton wrote:
> Linus Torvalds <torvalds@osdl.org> wrote:
> >
> >
> >
> > How about this patch?
>
> Seems sane. For after 2.6.6 ;)
>
> > +static inline long open(const char * name, int mode, int flags)
> > +{
> > + return sys_open((const char __user *) name, mode, flags);
> > +}
>
> We may as well stick the get_fs()/set_fs() stuff in here as well - all
> callers need to do it, after all. After which it would best be uninlined.

if you're going to modify callers, why not make them use open_filp()
instead of sys_open etc.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]