Re: 2.6.6-rc3: modular DVB tda1004x broken

Jörn Engel
2004-05-04T09:35:35Z

On Tue, 4 May 2004 01:14:50 +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> On Tue, May 04, 2004 at 12:33:17AM +0200, Jörn Engel wrote:
> > That cannot be all. What about these two? Not sure if my patch is
> > correct or it should rather s/O_RDONLY/FMODE_READ/.
>
> WTF does that have to sys_open(9) or open(9)?
>
> And no, dentry_open() does not take FMODE_... - open_namei() does,
> but dentry_open() takes flags unchanged. Just take a look at
> fs/open.c::filp_open() - flags are passed unchanged.

True, stupid me.

Jörn

--
It does not matter how slowly you go, so long as you do not stop.
-- Confucius