Re: 2.6.6-rc3: modular DVB tda1004x broken

David Mosberger
2004-05-04T16:44:33Z

>>>>> On Tue, 4 May 2004 09:55:55 +0200, Arjan van de Ven <arjanv@redhat.com> said:

Arjan> On Mon, May 03, 2004 at 03:39:08PM -0700, David Mosberger wrote:
>> >>>>> On Mon, 03 May 2004 23:07:04 +0200, Arjan van de Ven <arjanv@redhat.com> said:

Arjan> Exporting sys_mlock() for a kernel module soooo sounds wrong
Arjan> to me

>> On what grounds? What alternative are you suggesting?

Arjan> if the module wants to pin userspace pages there are plenty
Arjan> of alternatives. Heck I suspect what they want is to mmap a
Arjan> device like most V4L drivers do, instead of doing it the
Arjan> windows way (let the app malloc and then pin)

You may well be right (it's hard to tell what they're using mlock()
for since its called from the binary-only portion of the driver).
However, as long as x86 supports the _syscallN() macros, they won't
change.

--david