From: Chris Ball <cjb@laptop.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andres Salomon <dilinger@queued.net>
Subject: [PATCH] olpc: fix model detection without OFW
Date: Fri, 13 Feb 2009 20:56:18 -0500 [thread overview]
Message-ID: <m3mycpye65.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <1222208409.16003.25.camel@brick> (Harvey Harrison's message of "Tue, 23 Sep 2008 15:20:09 -0700")
Harvey's endianness patch (e51a1ac2dfca9ad869471e88f828281db7e810c0)
breaks model comparison on OLPC; the value 0xc2 needs to be scaled
up by olpc_board(). The pre-patch version was wrong, but accidentally
worked anyway (big-endian 0xc2 is big enough to satisfy all other
board revisions, but little endian 0xc2 is not).
Signed-off-by: Chris Ball <cjb@laptop.org>
---
arch/x86/kernel/olpc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/olpc.c b/arch/x86/kernel/olpc.c
index 7a13fac..4006c52 100644
--- a/arch/x86/kernel/olpc.c
+++ b/arch/x86/kernel/olpc.c
@@ -203,7 +203,7 @@ static void __init platform_detect(void)
static void __init platform_detect(void)
{
/* stopgap until OFW support is added to the kernel */
- olpc_platform_info.boardrev = 0xc2;
+ olpc_platform_info.boardrev = olpc_board(0xc2);
}
#endif
--
1.6.1.3
next prev parent reply other threads:[~2009-02-14 2:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 22:20 [PATCH] olpc: fix endian bug in openfirmware workaround Harvey Harrison
2008-09-24 7:53 ` Ingo Molnar
2009-02-14 1:56 ` Chris Ball [this message]
2009-02-14 4:19 ` [PATCH] olpc: fix model detection without OFW Andres Salomon
2009-02-14 21:43 ` Ingo Molnar
2009-02-14 21:53 ` Andres Salomon
2009-02-14 22:14 ` Ingo Molnar
2009-02-14 22:32 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mycpye65.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox