linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Osterlund <petero2@telia.com>
To: Norbert Preining <preining@logic.at>
Cc: linux-kernel@vger.kernel.org, hal@freedesktop.org
Subject: Re: cannot eject drive using pktcdvd
Date: 30 Dec 2004 00:11:54 +0100	[thread overview]
Message-ID: <m3mzvwya11.fsf@telia.com> (raw)
In-Reply-To: <20041223113248.GB27920@gamma.logic.tuwien.ac.at>

Norbert Preining <preining@logic.at> writes:

> Peter Osterlund wrote:
> > I can't reproduce any of these problems on my laptop. I run FC3 and
> > kernel 2.6.10-rc3-bk6. I tried both with a USB CDRW drive and an IDE
> > DVD+RW drive.
> 
> I can reproduce this problem, in fact I experienced it myself and
> disabled udftools.
> 
> > More info is needed. What distribution? What kernel? And please
> > provide strace logs from eject when it fails.
> 
> kernel:		2.6.10-rc3-mm1
> distribution:	debian/sid
...
>  open("/dev/hdc", O_RDONLY|O_NONBLOCK)   = 3
>  ioctl(3, CDROMEJECT, 0xbffffb68)        = -1 EIO (Input/output error)

I got a similar problem on FC3, but it doesn't have anything to do
with pktcdvd. The hal daemon is leaking a file descriptor when
checking a data DVD that doesn't contain a file system.

The effect is that /dev/hdc is kept open which makes eject attempts
from non-root users fail.

Here is a patch to fix the leak. I think it will apply also to the hal
cvs tree.

--- hal-0.4.2/hald/linux/block_class_device.c.old	2004-12-29 23:51:17.200288832 +0100
+++ hal-0.4.2/hald/linux/block_class_device.c	2004-12-29 23:51:23.040401000 +0100
@@ -1055,6 +1055,7 @@
 				if (is_cdrom) {
 					/* volume_id cannot probe blank/audio discs etc,
 					 * so don't fail for them, just set vid to NULL */
+					volume_id_close (vid);
 					vid = NULL;
 				} else {
 					g_object_unref (child);

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340

  reply	other threads:[~2004-12-29 23:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-14 22:29 cannot eject drive using pktcdvd Vince
2004-12-22 23:04 ` Peter Osterlund
2004-12-23 11:32   ` Norbert Preining
2004-12-29 23:11     ` Peter Osterlund [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-10-25 14:48 2.6.9-mm1, kernel Ooops in visor_open Norbert Preining
2004-10-26  4:43 ` Greg KH
2004-11-02  6:38   ` Norbert Preining
2004-11-05 23:10     ` Greg KH
2004-11-06  9:32       ` Norbert Preining

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3mzvwya11.fsf@telia.com \
    --to=petero2@telia.com \
    --cc=hal@freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=preining@logic.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).