From: Andi Kleen <ak@muc.de>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: linux-kernel@vger.kernel.org, tom.l.nguyen@intel.com
Subject: Re: [Patch 1/2] Disable SW irqbalance/irqaffinity for E7520/E7320/E7525
Date: Fri, 24 Sep 2004 13:36:16 +0200 [thread overview]
Message-ID: <m3mzzf99vz.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <2HSdY-7dr-3@gated-at.bofh.it> (Suresh Siddha's message of "Fri, 24 Sep 2004 09:00:19 +0200")
Suresh Siddha <suresh.b.siddha@intel.com> writes:
> Set TARGET_CPUS on x86_64 to cpu_online_map. This brings the code inline
> with x86 mach-default
And breaks compilation with MSI on. Here's a hackish workaround
that will probably fail with >64 CPUs.
Proper fix would be to fix MSI to deal with cpumasks properly
-Andi
diff -u linux/drivers/pci/msi.c-o linux/drivers/pci/msi.c
--- linux/drivers/pci/msi.c-o 2004-09-24 13:03:44.000000000 +0200
+++ linux/drivers/pci/msi.c 2004-09-24 13:34:18.000000000 +0200
@@ -282,7 +282,8 @@
msi_address->lo_address.u.dest_mode = MSI_DEST_MODE;
msi_address->lo_address.u.redirection_hint = MSI_REDIRECTION_HINT_MODE;
msi_address->lo_address.u.dest_id = dest_id;
- msi_address->lo_address.value |= (MSI_TARGET_CPU << MSI_TARGET_CPU_SHIFT);
+ /* FIXME: broken for >64 CPUs */
+ msi_address->lo_address.value |= (*cpus_addr(MSI_TARGET_CPU) << MSI_TARGET_CPU_SHIFT);
}
static int msi_free_vector(struct pci_dev* dev, int vector, int reassign);
diff -u linux/include/asm-x86_64/smp.h-o linux/include/asm-x86_64/smp.h
next parent reply other threads:[~2004-09-24 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2HSdY-7dr-3@gated-at.bofh.it>
2004-09-24 11:36 ` Andi Kleen [this message]
2004-09-24 11:39 ` [Patch 1/2] Disable SW irqbalance/irqaffinity for E7520/E7320/E7525 William Lee Irwin III
2004-10-01 1:32 ` [Patch 1/2] Disable SW irqbalance/irqaffinity for E7520/E7320/E7525 - change TARGET_CPUS on x86_64 Suresh Siddha
2004-10-01 6:01 ` Andrew Morton
2004-10-01 7:19 ` Andi Kleen
2004-10-01 19:02 ` James Cleverdon
2004-10-01 19:17 ` Andrew Morton
2004-10-01 19:31 ` Andi Kleen
2004-09-24 6:36 [Patch 1/2] Disable SW irqbalance/irqaffinity for E7520/E7320/E7525 Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mzzf99vz.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox