From: Andi Kleen <ak@muc.de>
To: "Spinka, Kristofer" <kspinka@style.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Unserializing ioctl() system calls
Date: Sat, 22 May 2004 10:03:15 +0200 [thread overview]
Message-ID: <m3n040q470.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <1YuKj-2FZ-9@gated-at.bofh.it> (Kristofer Spinka's message of "Sat, 22 May 2004 04:50:07 +0200")
"Spinka, Kristofer" <kspinka@style.net> writes:
> I noticed that even in the 2.6.6 code, callers to ioctl system call
> (sys_ioctl in fs/ioctl.c) are serialized with {lock,unlock}_kernel().
>
> I realize that many kernel modules, and POSIX for that matter, may not
> be ready to make this more concurrent.
POSIX doesn't care how the kernel implements locking.
> I propose adding a flag to indicate that the underlying module would
> like to support its own concurrency management, and thus we avoid
> grabbing the BKL around the f_op->ioctl call.
Better would be probably a unlocked_ioctl() entry point in f_op. Should
be pretty easy to implement.
There is also the additional issue that on 64bit systems with 32bit
userland the ioctl emulation currently relies on the BKL.
-Andi
next parent reply other threads:[~2004-05-22 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1YuKj-2FZ-9@gated-at.bofh.it>
2004-05-22 8:03 ` Andi Kleen [this message]
2004-05-22 2:46 Unserializing ioctl() system calls Spinka, Kristofer
2004-05-22 2:54 ` viro
2004-05-22 3:35 ` Spinka, Kristofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3n040q470.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=kspinka@style.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox