From: Peter Osterlund <petero2@telia.com>
To: balagi@justmail.de
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
akpm@osdl.org
Subject: Re: [PATCH 3/4] 2.6.18-mm2 pktcdvd: restructure code
Date: 03 Oct 2006 00:00:29 +0200 [thread overview]
Message-ID: <m3odsue5tu.fsf@telia.com> (raw)
In-Reply-To: <op.tgratfqriudtyh@master>
"Thomas Maier" <balagi@justmail.de> writes:
> this patch 3/4 for pktcdvd against Linux 2.6.18 (stable)
> or 2.6.18-mm2 restructures the code for better readability
> and prepares it for the sysfs interface code following in patch 4/4.
This is still kind of hard to review. It would be much better if it
was split in two parts, where the first part only moved existing
functions around, and the second part added other neat things, such as
the pkt_find_dev() and pkt_find_dev_bdev() functions.
--
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340
prev parent reply other threads:[~2006-10-02 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 18:54 [PATCH 3/4] 2.6.18-mm2 pktcdvd: restructure code Thomas Maier
2006-10-02 21:47 ` Peter Osterlund
2006-10-02 22:00 ` Peter Osterlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3odsue5tu.fsf@telia.com \
--to=petero2@telia.com \
--cc=akpm@osdl.org \
--cc=balagi@justmail.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox