Re: Problems with eject and pktcdvd

[Peter Osterlund <petero2@telia.com>]

Damian Pietras <daper@daper.net> writes:

> Now I can mount CD-R, CD-RW, DVD+RW using pktcdvd.
> 
> Something strange happend when I copied files to DVD+RW und used eject.
> After some time eject exitet, but the disc was stil in the burner, I was
> allowed to open it by pressing the eject button, but then:
> 
> hda: media error (bad sector): status=0x51 { DriveReady SeekComplete Error }
> hda: media error (bad sector): error=0x34 { AbortedCommand LastFailedSense=0x03

Thanks for testing. Please try this patch: It makes sure not to unlock
the door if the disc is in use.

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index f92d22f..a43f68d 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -2436,7 +2436,8 @@ static int pkt_ioctl(struct block_device
 		 * The door gets locked when the device is opened, so we
 		 * have to unlock it or else the eject command fails.
 		 */
-		pkt_lock_door(pd, 0);
+		if (pd->refcnt == 1)
+			pkt_lock_door(pd, 0);
 		return blkdev_ioctl(pd->bdev, file, cmd, arg);
 
 	default:

> And also many messages like this:
> pktcdvd: Unknown ioctl for pktcdvd0 (5326)
> 
> When inserting CD-R I get:
> pktcdvd: Wrong disc profile (9)
> pktcdvd: pktcdvd0 failed probe
> 
> but everything works OK.

Yes, those messages are quite useless except for debugging. I'll make
them go away.

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340