Re: [PATCH] patch's for vmware 2.0.4 for use with linux-2.4.8 kernel

Re: [PATCH] patch's for vmware 2.0.4 for use with linux-2.4.8 kernel

[Martin Knoblauch]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

> [PATCH] patch's for vmware 2.0.4 for use with linux-2.4.8 kernel
> 
> From: Jason Thomas (jason@topic.com.au)
> Date: Thu Aug 16 2001 - 03:49:38 EST
> 
> 
> attached are two very small patches for those that want them. they make
> vmware's kernel modules compile with 2.4.8. Its not all my work, its a
> combination of what was posted a while back and my work.
> 
Jason,

 a small gotcha in your vmmon patch. You moved up hostif.h in driver.c,
but you forgot to remove the original include. See my attached new
version of the patch.

Martin
-- 
------------------------------------------------------------------
Martin Knoblauch         |    email:  Martin.Knoblauch@TeraPort.de
TeraPort GmbH            |    Phone:  +49-89-510857-309
C+ITS                    |    Fax:    +49-89-510857-111
http://www.teraport.de   |    Mobile: +49-170-4904759

[-- Attachment #2: vmmon-248.patch --]
[-- Type: text/plain, Size: 1255 bytes --]

diff -ur vmmon-only.orig/linux/driver.c vmmon-only/linux/driver.c
--- vmmon-only.orig/linux/driver.c	Thu May 10 03:46:42 2001
+++ vmmon-only/linux/driver.c	Fri Aug 17 14:03:30 2001
@@ -9,6 +9,7 @@
 #endif 
 
 #include "driver-config.h"
+#include "hostif.h"
 
 #ifdef KERNEL_2_1
 #define EXPORT_SYMTAB
@@ -19,7 +20,7 @@
 #include <linux/module.h>
 #include <linux/version.h>
 #include <linux/sched.h>
-#include <linux/malloc.h>
+#include <linux/slab.h>
 
 #ifdef __SMP__
 #include <linux/smp.h>
@@ -54,7 +55,6 @@
 #include "vmx86.h"
 #include "initblock.h"
 #include "task.h"
-#include "hostif.h"
 #include "driver.h"
 #include "speaker_reg.h"
 #include "vtrace.h"
@@ -925,7 +925,7 @@
 	  current->fsuid == current->uid &&
           current->egid == current->gid &&
 	  current->fsgid == current->gid) {
-	 current->dumpable = 1;
+	 current->mm->dumpable = 1;
       }
       break;
 
diff -ur vmmon-only.orig/linux/hostif.c vmmon-only/linux/hostif.c
--- vmmon-only.orig/linux/hostif.c	Thu May 10 03:46:42 2001
+++ vmmon-only/linux/hostif.c	Fri Aug 17 11:11:00 2001
@@ -22,7 +22,7 @@
 #include <linux/binfmts.h>
 #include <linux/fs.h>
 #include <linux/mm.h>
-#include <linux/malloc.h>
+#include <linux/slab.h>
 
 #ifdef KERNEL_2_1
 #  ifdef KERNEL_2_3_25

[OT?] Re: [PATCH] patch's for vmware 2.0.4 for use with linux-2.4.8 kernel

[Alexander Hoogerhuis]

Martin Knoblauch <Martin.Knoblauch@TeraPort.de> writes:

> > [PATCH] patch's for vmware 2.0.4 for use with linux-2.4.8 kernel
> > 
> > From: Jason Thomas (jason@topic.com.au)
> > Date: Thu Aug 16 2001 - 03:49:38 EST
> > 
> > 
> > attached are two very small patches for those that want them. they make
> > vmware's kernel modules compile with 2.4.8. Its not all my work, its a
> > combination of what was posted a while back and my work.
> > 
> Jason,
> 
>  a small gotcha in your vmmon patch. You moved up hostif.h in driver.c,
> but you forgot to remove the original include. See my attached new
> version of the patch.
> 
> Martin
> -- 

I've applied the patch with your fixes, and I've always noticed that
VMware seem to leak a bit of memory (occording to top and ps). Running
with 128Mb in a Win2k box it started off at 161Mb process size (140Mb
RSS) and within 5 minutes it had turned into 203Mb process size (still
only 140Mb RSS). Have anyone seen similar behavior, and does anyone
have any pointers to where I can find more info on it?

mvh,
A
-- 
Alexander Hoogerhuis
FYI: perl -e 'print $i=pack(c5,(41*2),sqrt(7056),(unpack(c,H)-2),oct(115),10);'

Re: [OT?] Re: [PATCH] patch's for vmware 2.0.4 for use with linux-2.4.8 kernel

[Martin Knoblauch]

Alexander Hoogerhuis wrote:
> 
> 
> I've applied the patch with your fixes, and I've always noticed that
> VMware seem to leak a bit of memory (occording to top and ps). Running
> with 128Mb in a Win2k box it started off at 161Mb process size (140Mb
> RSS) and within 5 minutes it had turned into 203Mb process size (still
> only 140Mb RSS). Have anyone seen similar behavior, and does anyone
> have any pointers to where I can find more info on it?
> 

 probably better to ask the vmware folks. They also have some news
groups served from news.vmware.com

Martin
-- 
------------------------------------------------------------------
Martin Knoblauch         |    email:  Martin.Knoblauch@TeraPort.de
TeraPort GmbH            |    Phone:  +49-89-510857-309
C+ITS                    |    Fax:    +49-89-510857-111
http://www.teraport.de   |    Mobile: +49-170-4904759