From: Krzysztof Halasa <khc@pm.waw.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] document Acked-by:
Date: Sun, 03 Jun 2007 02:23:01 +0200 [thread overview]
Message-ID: <m3ps4dubru.fsf@maximus.localdomain> (raw)
In-Reply-To: <20070602104700.53b6b811.akpm@linux-foundation.org> (Andrew Morton's message of "Sat, 2 Jun 2007 10:47:00 -0700")
Andrew Morton <akpm@linux-foundation.org> writes:
> I do that often. It's useful information. If person X sends an fbdev
> patch and Tony says "whoa, neat" and I send the patch to Linus then
> Linus could
> well think "wtf, Andrew doesn't know anything about fbdev". So I do s/whoa
> neat/Acked-by:/ to tell the world that someone who knows something has
> looked at the change.
Makes sense.
> +Acked-by: does not necessarily indicate acknowledgement of the entire patch.
> +For example, if a patch affects multiple subsystems and has an Acked-by: from
> +one subsystem maintainer then this usually indicates acknowledgement of just
> +the part which affects that maintainer's code.
I'd add, just to be explicit, that acked-by does not necessarily mean
the acker is a maintainer of any subsystem the patch touches, or
generally maintainer of any code.
Unless it isn't true, of course, i.e., unless we really want to limit
expressing non-maintainers opinion in form of ack and nak.
--
Krzysztof Halasa
next prev parent reply other threads:[~2007-06-03 0:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 2:09 [patch 1/1] document Acked-by: akpm
2007-06-01 5:32 ` Valdis.Kletnieks
2007-06-01 6:10 ` H. Peter Anvin
2007-06-01 10:53 ` John Anthony Kazos Jr.
2007-06-01 19:27 ` Krzysztof Halasa
2007-06-01 19:37 ` Scott Preece
2007-06-01 20:00 ` Andrew Morton
2007-06-01 20:04 ` Andrew Morton
2007-06-02 13:34 ` debian developer
2007-06-02 17:13 ` Jan Engelhardt
2007-06-02 19:34 ` Valdis.Kletnieks
2007-06-01 22:10 ` Krzysztof Halasa
2007-06-01 22:17 ` H. Peter Anvin
2007-06-01 22:42 ` Krzysztof Halasa
2007-06-02 0:37 ` John Anthony Kazos Jr.
2007-06-02 0:56 ` Krzysztof Halasa
2007-06-02 1:36 ` Valdis.Kletnieks
2007-06-01 17:27 ` Valdis.Kletnieks
2007-06-01 17:35 ` Andrew Morton
2007-06-01 18:14 ` Dave Jones
2007-06-01 18:22 ` Andrew Morton
2007-06-01 18:28 ` Dave Jones
2007-06-02 17:17 ` Jan Engelhardt
2007-06-02 18:00 ` John Anthony Kazos Jr.
2007-06-02 19:07 ` Sam Ravnborg
2007-06-02 14:11 ` Adrian Bunk
2007-06-02 17:47 ` Andrew Morton
2007-06-02 17:55 ` Adrian Bunk
2007-06-03 0:23 ` Krzysztof Halasa [this message]
2007-06-03 2:57 ` Scott Preece
2007-06-03 4:06 ` Randy Dunlap
2007-06-03 4:15 ` Andrew Morton
2007-06-03 18:31 ` Scott Preece
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ps4dubru.fsf@maximus.localdomain \
--to=khc@pm.waw.pl \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox